Feat/multichain reputation rebased hardhat 2#1238
Merged
Conversation
…n-reputation-rebased-hardhat-2
kronosapiens
reviewed
Apr 6, 2024
Member
Author
|
I've included your suggested changes to the migrations, though really they should have been deleted in #1196 😄 |
area
force-pushed
the
feat/multichain-reputation-rebased-hardhat-2
branch
from
6cb7ac0 to
dd974be
Compare
area
force-pushed
the
feat/multichain-reputation-rebased-hardhat-2
branch
from
dd974be to
15c78f3
Compare
kronosapiens
approved these changes
Apr 8, 2024
|
|
||
| bool success = callThroughBridgeWithGuards(payload); | ||
|
|
||
| if (success) { |
Contributor
There was a problem hiding this comment.
Could do this as
require(success, "colony-network-bridging-tx-unsuccessful");
emit ReputationUpdateSentToBridge(_colony, _updateNumber);
| reputationUpdateCount[block.chainid][colonyAddress] | ||
| ); | ||
| return skill.children[_childSkillIndex]; | ||
| return; |
Contributor
There was a problem hiding this comment.
Why not do an else here?
Member
Author
There was a problem hiding this comment.
This is the same pattern as came up recently, namely that I don't want to forget that we introduced the else to implicitly mean 'and do nothing else in the if branch', and then introduce something after the if statement at a later date that breaks that assumption.
area
force-pushed
the
feat/multichain-reputation-rebased-hardhat-2
branch
from
8a1a142 to
0d9436c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended to be the same as #1216 but based on #1196. #1237 is based on this branch.