changed usage of code as identifier.#1100
Open
nishant-sachdeva wants to merge 1 commit intoJoinColony:developfrom
Open
changed usage of code as identifier.#1100nishant-sachdeva wants to merge 1 commit intoJoinColony:developfrom
nishant-sachdeva wants to merge 1 commit intoJoinColony:developfrom
Conversation
… in upcoming changes in solidity
|
|
Contributor
|
@nishant-sachdeva thanks for letting us know! Can you sign the CLA so we can move forward with the review? |
Contributor
|
Making a note to check with front-end about whether they reference the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're currently implementing immutable for dynamic types in the compiler. With things like arrays and structs, however, it's much more tedious to enforce the immutability at contract construction time (and not everyone even thinks that this immutability is desirable) so we decided to make them freely writable at that stage instead. To make this clear we're introducing a new keyword: code. This is a breaking change so it will only really become a keyword in 0.9.0.
Turns out that colonyNetwork has one instance of code being used as an identifier. This PR changes its name for future compatibility and also will help us test the compiler against colonyNetwork without having to maintain a fork just for this small tweak.