Repository navigation
Conversation
BinOp::DoubleSlash is available with the luau feature, but the trivia matches in trivia.rs and trivia_util.rs only handled it under lua53, so hanging a `//` expression or formatting one with comments around the operator panicked with "unknown node DoubleSlash" in luau-only builds. Fixes JohnnyMorganz#1190
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1190
When StyLua is built with
luaubut notlua53, hanging a//expression (or formatting one with comments around the operator) panicked withunknown node DoubleSlash.4bd007e enabled
DoubleSlashforluauinexpression.rs, but three trivia matches still only handled it underlua53:binop_trivia!intrivia.rs, andGetLeadingTrivia/GetTrailingTriviaforBinOpintrivia_util.rs. This gatesDoubleSlashwithany(feature = "luau", feature = "lua53")in all three, splitting it into its own arm where it was grouped with thelua53-only operators.The existing
floor-division.luaLuau test only hadlocal x = 1 // 2, which never hangs. It now also covers a long//expression and comments around the operator.