fix: support windows generator builds#336
Merged
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the repo’s Roslyn compiler package baseline to improve Windows compatibility for building the source generator, and refreshes the affected NuGet lock files to reflect the new resolution.
Changes:
- Downgrade
Microsoft.CodeAnalysis.CSharp(central version) from 5.3.0 to 5.0.0 to align with SDK-compatible Roslyn baselines. - Regenerate
packages.lock.jsonfor the generator and generator tests to lock the updated Roslyn dependency graph. - Refresh the benchmark lock file to reflect the updated central package version request.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Directory.Packages.props | Lowers centrally-managed Microsoft.CodeAnalysis.CSharp version to 5.0.0. |
| src/PatternKit.Generators/packages.lock.json | Updates locked Roslyn/compiler dependencies for the generator project. |
| test/PatternKit.Generators.Tests/packages.lock.json | Updates locked Roslyn/compiler dependencies used by generator tests across TFMs. |
| benchmarks/PatternKit.Benchmarks/packages.lock.json | Refreshes lock file to reflect updated central Roslyn version request. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Test Results 1 files 1 suites 2m 14s ⏱️ Results for commit cfe5ef0. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
==========================================
+ Coverage 89.65% 95.64% +5.99%
==========================================
Files 486 486
Lines 40002 40002
Branches 5756 5756
==========================================
+ Hits 35864 38261 +2397
+ Misses 1878 1741 -137
+ Partials 2260 0 -2260
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
🔍 PR Validation ResultsVersion: `` ✅ Validation Steps
📊 ArtifactsDry-run artifacts have been uploaded and will be available for 7 days. This comment was automatically generated by the PR validation workflow. |
Contributor
Code Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation