63 add graph driver example#64
Open
sgoldenCS wants to merge 3 commits into
Open
Conversation
Makes QoL improvements including: automatic conversion of lists to tuples for the input and output values for each edge of the graph, allowing a module object as an input to a function through a special "module.name" syntax, and a built-in print function to print out any data/module object to stdout.
This workflow does everything the current example_workflow does, except it does not output images. This is because the logdir is currently passed to the trainer and analysis modules as an input argument which is out of order. We may need to update the graph driver to allow for kwargs, but for now, this is a good example of what the workflow could look like.
sgoldenCS
added
documentation
If we make a few small changes to the logging within the trainer and analysis, we can pass it in through the configuration.
Contributor
Author
|
I've made a few changes to the analysis and trainer modules which shouldn't affect them for previous uses, but allow them to have the log directory passed in as a configuration option. This allows them to produce all of the output graphs that were missing before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request covers the creation of a new graph driver example derived from the existing workflow example in the core. There are only two changes that would affect existing users in this PR:
__init__.pyfile for the toolkit now imports from most sub-packages (data_parsers, data_preps, models, trainers, and analyses)One thing to note: The graph driver does not currently allow for keyword-arguments which limits the example driver. Specifically, the trainer and analysis are not given a
logdirargument, so they do not output any graphs. I think this issue will need to be dealt with separately; either we need to change the way the modules obtain thelogdir(perhaps through their__init__?) or we need to figure out a solution for passing in keyword arguments. While the PR is in review, I may try to find a quick workaround, but it's likely these will need to be fixed in a separate issue/branch.