Added unit tests for BWAPI types to verify parameter-less getters can be called without causing exceptions, and none returns null.

Author: Bytekeeper

src/main/java/bwapi/TextColor.java

@@ -48,7 +48,7 @@ public static String formatText(final String text, final TextColor format) {
     }
 
     //SINCE 4.2
-    //C hecks if the given character is a color-changing control code.
+    //C checks if the given character is a color-changing control code.
     boolean isColor() {
         final int c = this.id;
         return (2 <= c && c <= 8) || (14 <= c && c <= 17) || (21 <= c && c <= 31);

src/test/java/bwapi/PlayerTypeTest.java

@@ -0,0 +1,12 @@
+package bwapi;
+
+import org.junit.Test;
+
+import java.lang.reflect.InvocationTargetException;
+
+public class PlayerTypeTest {
+    @Test
+    public void ensureSimpleGettersReturnNonNullAndDontFail() throws InvocationTargetException, IllegalAccessException {
+        TypeTester.ensureSimpleGettersReturnNonNullAndDontFail(WeaponType.class);
+    }
+}

src/test/java/bwapi/TechTypeTest.java

@@ -25,4 +25,10 @@ public void testArraySizes() throws IllegalAccessException {
             }
         }
     }
+
+    @Test
+    public void ensureSimpleGettersReturnNonNullAndDontFail() throws InvocationTargetException, IllegalAccessException {
+        TypeTester.ensureSimpleGettersReturnNonNullAndDontFail(TechType.class);
+    }
+
 }

src/test/java/bwapi/TypeTester.java

@@ -0,0 +1,30 @@
+package bwapi;
+
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+import java.util.Arrays;
+import java.util.List;
+import java.util.stream.Collectors;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+class TypeTester {
+    private TypeTester() {
+        // Utility class
+    }
+
+    static void ensureSimpleGettersReturnNonNullAndDontFail(Class<? extends Enum<?>> typeEnumClass) throws InvocationTargetException, IllegalAccessException {
+        List<Method> simpleGetters = Arrays.stream(typeEnumClass.getMethods())
+                .filter(it -> it.getParameterCount() == 0 && it.getReturnType() != Void.TYPE)
+                .collect(Collectors.toList());
+        for (Enum<?> type : typeEnumClass.getEnumConstants()) {
+            for (Method getter : simpleGetters) {
+                // WHEN
+                Object result = getter.invoke(type);
+
+                // THEN
+                assertThat(result).describedAs("When calling " + getter.getName()).isNotNull();
+            }
+        }
+    }
+}

src/test/java/bwapi/UnitTypeTest.java

@@ -0,0 +1,12 @@
+package bwapi;
+
+import org.junit.Test;
+
+import java.lang.reflect.InvocationTargetException;
+
+public class UnitTypeTest {
+    @Test
+    public void ensureSimpleGettersReturnNonNullAndDontFail() throws InvocationTargetException, IllegalAccessException {
+        TypeTester.ensureSimpleGettersReturnNonNullAndDontFail(WeaponType.class);
+    }
+}

src/test/java/bwapi/UpgradeTypeTest.java

@@ -0,0 +1,13 @@
+package bwapi;
+
+import org.junit.Test;
+
+import java.lang.reflect.InvocationTargetException;
+
+public class UpgradeTypeTest {
+    @Test
+    public void ensureSimpleGettersReturnNonNullAndDontFail() throws InvocationTargetException, IllegalAccessException {
+        TypeTester.ensureSimpleGettersReturnNonNullAndDontFail(WeaponType.class);
+    }
+
+}

src/test/java/bwapi/WeaponTypeTest.java

@@ -0,0 +1,12 @@
+package bwapi;
+
+import org.junit.Test;
+
+import java.lang.reflect.InvocationTargetException;
+
+public class WeaponTypeTest {
+    @Test
+    public void ensureSimpleGettersReturnNonNullAndDontFail() throws InvocationTargetException, IllegalAccessException {
+        TypeTester.ensureSimpleGettersReturnNonNullAndDontFail(WeaponType.class);
+    }
+}