Added a unit test for string put/get. (And changed the implementation, although it is at most ~10% faster in local benchmarking)

Author: Bytekeeper

src/main/java/bwapi/WrappedBuffer.java

@@ -72,15 +72,17 @@ void putDouble(final int offset, final double value) {
     }
 
     String getString(final int offset, final int maxLen) {
-        final byte[] buf = new byte[maxLen];
-
-        unsafe.copyMemory(null, address + offset, buf, Unsafe.ARRAY_BYTE_BASE_OFFSET, maxLen);
-
-        int len = 0;
-        while (len < maxLen && buf[len] != 0) {
-            ++len;
+        buffer.position(offset);
+        ByteBuffer source = buffer.slice();
+        int rem = maxLen - 1;
+        while (source.get() != 0 && rem > 0) {
+            rem--;
+        }
+        if (rem > 0) {
+            source.position(source.position() - 1);
         }
-        return new String(buf, 0, len, charSet);
+        source.flip();
+        return charSet.decode(source).toString();
     }
 
     void putString(final int offset, final int maxLen, final String string) {

src/test/java/bwapi/WrappedBufferTest.java

@@ -0,0 +1,37 @@
+package bwapi;
+
+import org.junit.Test;
+
+import java.nio.ByteBuffer;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+public class WrappedBufferTest {
+    private WrappedBuffer sut = new WrappedBuffer(ByteBuffer.allocateDirect(1024));
+
+    @Test
+    public void shouldGetAndSetStrings() {
+        // GIVEN
+        String testString = "Test";
+        sut.putString(123, 100, testString);
+
+        // WHEN
+        String readString = sut.getString(123, 100);
+
+        // THEN
+        assertThat(readString).isEqualTo(testString);
+    }
+
+    @Test
+    public void shouldCutOffAtMaxLength() {
+        // GIVEN
+        String testString = "Test";
+        sut.putString(123, 100, testString);
+
+        // WHEN
+        String readString = sut.getString(123, 3);
+
+        // THEN
+        assertThat(readString).isEqualTo(testString.substring(0, 3));
+    }
+}