fix: devcontainer tweaks#401
Open
allison-truhlar wants to merge 2 commits into
Open
Conversation
An unpinned (latest) pixi can compute a different workspace hash and reject pixi.lock as not up-to-date. Pin PIXI_VERSION=0.66.0 in the image build.
The ownership guard only checked the top-level .pixi dir and hardcoded 1000:1000, so it missed root-owned contents under a correctly-owned top dir and broke when updateRemoteUserUID remapped vscode's UID. Probe the whole tree (find -quit) and chown to vscode by name instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains some fixes I had to make to get the updated devcontainer running for me - pinning the version of pixi in the container and some permission difference arising from my still using Docker on Linux vs. Podman.
@krokicki