Skip to content

feat: allow changing execute permission#363

Open
allison-truhlar wants to merge 7 commits intomainfrom
allow-changing-execute-permission
Open

feat: allow changing execute permission#363
allison-truhlar wants to merge 7 commits intomainfrom
allow-changing-execute-permission

Conversation

@allison-truhlar
Copy link
Copy Markdown
Collaborator

Clickup id: 86ah03cn7

This PR allows the user to change the execute permissions on files and folders from the properties drawer. It also adds the ability to change the "sticky bit" permission - whether only the owner can rename or delete files in a directory. The latter is displayed in a new table under the main permissions table in the properties drawer and can be changed via a new checkbox in the ChangePermissions dialog, for directories only.

@krokicki

@allison-truhlar
Copy link
Copy Markdown
Collaborator Author

@neomorphic @cgoina Here is what the properties panel looks like with group sticky bit line in the table.

What do you think of the wording? I feel torn about whether it would be more clear to use the technical language, if we assume the main users of these special permissions would be more technical, versus the less-technical language I'm using now to try to make it understandable to users not familiar with sticky bits (like myself prior to this PR):

Example where the directory has the same group ownership (scicompsoft) as the user's primary group (scicompsoft), and the group sticky bit isn't set:
Screenshot 2026-04-30 at 12 54 39 PM

Example where the directory has a different group ownership (opendata) than the user's primary group (scicompsoft) as well as the parent directory (scicompsoft), and the group sticky bit is set:
Screenshot 2026-04-30 at 12 54 57 PM

For completeness, here is what the option looks like in the change permissions dialog:
Screenshot 2026-04-30 at 12 55 15 PM

@neomorphic
Copy link
Copy Markdown
Member

I think a slight tweak would be "New files created in this directory belong to group opendata, regardless of the file creator's primary group" This clarifies that it is the file creators primary group and not the folder creators primary group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants