style: hide data link path format options in data link dialog#362
Open
allison-truhlar wants to merge 2 commits intomainfrom
Open
style: hide data link path format options in data link dialog#362allison-truhlar wants to merge 2 commits intomainfrom
allison-truhlar wants to merge 2 commits intomainfrom
Conversation
Split the link-name-format radios into a standalone exported SubpathModeOptions component and add a hideSubpathMode prop so callers can render only the automatic-links checkbox.
Restore the original create-data-link dialog layout with the automatic-links checkbox above the Create/Cancel buttons, and move the link name format radios and preview into a collapsed "Advanced settings" accordion below the buttons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clickup id: 86agxqrp7
This PR hides the options for formatting the data link path in the data link dialog, under an accordion labeled "advanced settings". This suggestion came from Diyi, based on new user confusion about what these options mean. It also reverts the organization of the data link dialog back to what it was before adding these options - specifically, the "enable automatic data link creation" option is moved above the create/cancel buttons, and the advanced options are kept below the buttons.
@krokicki