feat: data link code snippets dialog #266
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also fixes location of the copy icon for the code blocks
- in the DataLinkUsageDialog, the copied message was not showing due to a CSS issue. However, in addressing this, I realized that this component was recreating logic from the CopyTooltip component and reworked it to use that component
allison-truhlar
requested review from
neomorphic
and removed request for
neomorphic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clickup id: 86acuxatq, 86accr60r, 86accr5yg
Note: this PR only includes instructions for Napari, Python, Fiji, and VVDViewer. I separated the Java instructions into a new ticket - this snippet isn't ready yet.
This PR adds a data link usage dialog that can be accessed from the Zarr preview panel (Zarr directories only) or the properties panel (all directories). The dialog shows instructions and copy-able code snippets, organized into tabs by language. The top of the dialog always has a button to copy just the data link.
The PR also extracts two reusable dialog button components - one that is an icon button with a tooltip on hover and one that allows for text on the button (no tooltip).
@krokicki @neomorphic @cgoina