Skip to content

Conversation

@cgoina
Copy link
Collaborator

@cgoina cgoina commented May 14, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @cgoina,

It looks like this pull-request is has been made against the JaneliaSciComp/easifish main branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the JaneliaSciComp/easifish dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@cgoina cgoina merged commit 22c17b4 into main May 15, 2025
0 of 9 checks passed
@cgoina cgoina deleted the spot-intensities branch May 15, 2025 21:36
@github-actions
Copy link

github-actions bot commented May 15, 2025

nf-core pipelines lint overall result: Failed ❌

Posted for pipeline commit 0b48e75

+| ✅ 222 tests passed       |+
#| ❔  11 tests were ignored |#
!| ❗  24 tests had warnings |!
-| ❌  40 tests failed       |-
Details

❌ Test failures:

  • files_exist - File not found: assets/nf-core-easifish_logo_light.png
  • files_exist - File not found: docs/images/nf-core-easifish_logo_light.png
  • files_exist - File not found: docs/images/nf-core-easifish_logo_dark.png
  • files_exist - File must be removed: lib/NfcoreTemplate.groovy
  • files_exist - File must be removed: lib/Utils.groovy
  • files_exist - File must be removed: lib/WorkflowMain.groovy
  • files_exist - File must be removed: lib/nfcore_external_java_deps.jar
  • nextflow_config - Plugin 'nf-validation' does not have a pinned version
  • nextflow_config - Config variable (incorrectly) found: params.max_cpus
  • nextflow_config - Config variable (incorrectly) found: params.max_memory
  • nextflow_config - Config variable (incorrectly) found: params.max_time
  • nextflow_config - Config default value incorrect: params.bigstream_config is set as ${projectDir}/conf/bigstream_config.yml in nextflow_schema.json but is /home/runner/work/easifish/easifish/conf/bigstream_config.yml in nextflow.config.
  • nextflow_config - Config default value incorrect: params.dask_config is set as ${projectDir}/conf/dask_config.yml in nextflow_schema.json but is /home/runner/work/easifish/easifish/conf/dask_config.yml in nextflow.config.
  • nextflow_config - Config default value incorrect: params.local_align_worker_cpus is set as 3 in nextflow_schema.json but is 1 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.bigstream_inv_use_root is set as true in nextflow_schema.json but is false in nextflow.config.
  • nextflow_config - Config default value incorrect: params.multiscale_spark_workers is set as 1 in nextflow_schema.json but is 0 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.multiscale_spark_worker_cores is set as 3 in nextflow_schema.json but is 0 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.multiscale_spark_driver_mem_gb is set as 1 in nextflow_schema.json but is 0 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.seg_channels is set as c1 in nextflow_schema.json but is `` in nextflow.config.
  • nextflow_config - Config default value incorrect: params.cellpose_log_config is set as ${projectDir}/conf/cellpose_logging_config.ini in nextflow_schema.json but is /home/runner/work/easifish/easifish/conf/cellpose_logging_config.ini in nextflow.config.
  • nextflow_config - Config default value incorrect: params.cellpose_dask_config is set as ${projectDir}/conf/dask_config.yml in nextflow_schema.json but is /home/runner/work/easifish/easifish/conf/dask_config.yml in nextflow.config.
  • nextflow_config - Config default value incorrect: params.cellpose_dask_workers is set as 10 in nextflow_schema.json but is 8 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.user_id is set as 0 in nextflow_schema.json but is 1001 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.group_id is set as 0 in nextflow_schema.json but is 118 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.singularity_cache_dir is set as $HOME/.singularity_cache in nextflow_schema.json but is /home/runner/.singularity_cache in nextflow.config.
  • files_unchanged - .github/CONTRIBUTING.md does not match the template
  • files_unchanged - .github/PULL_REQUEST_TEMPLATE.md does not match the template
  • files_unchanged - .github/workflows/branch.yml does not match the template
  • files_unchanged - .github/workflows/linting.yml does not match the template
  • actions_ci - Minimum pipeline NF version '23.04.0' is not tested in '.github/workflows/ci.yml'
  • schema_params - Param distributed_spot_extraction from nextflow config not found in nextflow_schema.json
  • schema_params - Param skip_warp_spots from nextflow config not found in nextflow_schema.json
  • schema_params - Param warped_spots_subdir from nextflow config not found in nextflow_schema.json
  • schema_params - Param warp_spots_cpus from nextflow config not found in nextflow_schema.json
  • schema_params - Param warp_spots_mem_in_gb from nextflow config not found in nextflow_schema.json
  • schema_params - Param bleeding_channel from nextflow config not found in nextflow_schema.json
  • schema_params - Default value for param bigstream_inv_use_root invalid: Schema default (True) does not match the config default (false)
  • schema_params - Default value for param bleed_channel invalid: Not in pipeline parameters. Check nextflow.config.
  • modules_json - Your modules.json file is outdated. It will be automatically generated by running any module command.
  • multiqc_config - assets/multiqc_config.yml not found.

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: assets/nf-core-easifish_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-easifish_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-easifish_logo_dark.png
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/easifish/easifish/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 3.2.0
  • Run at 2025-05-15 21:36:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants