Repository navigation
Stop live Commands from the Console - #869
Merged
Merged
Conversation
Preserve Console Stop and Requeue alongside email-code password setup. Register both sets of routes and HTTP tests, retaining shared-path CLI parity accounting. Validation: cargo test --locked; cargo clippy --all-targets -- -D warnings; cargo fmt --check; all 27 Console browser tests.
Preserve the Console installation entry alongside the expanded Console Stop implementation and test references.
This was referenced Oct 20, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Live Commands can now be stopped from their Console details, including while reading a Session log.
Closes #823
Evidence
After:
cargo test --test console console_stop_confirms -- --nocaptureverifies authentication, CSRF, confirmation, triage/requeue labels against fake GitHub, attribution, pushed completion and retained work with a waiting fake Harness.After:
python3 console/reproductions/session-stop.pyreturns HTTP 200 with Stop; Playwright follows the live Session's link.stop --jsonwas rejected, conflicting with ADR 0016.After:
cargo test --test stop json_stop_reports -- --nocapturechecks the outcome, retained work and labels for both endings. Both Stop routes list JSON CLI equivalents in the parity test.cargo test --locked,cargo fmt --check,cargo clippy --all-targets -- -D warnings, and all 27 Console Playwright tests pass. Browser checks cover cancellation, both confirmation choices, reduced motion, pushed outcomes and removal of stale Stop controls.Test seams:
Review coverage
Reviewed against
issue-776pinned at7788650using independent Standards and Spec reviewers. Standards: 2 findings fixed (JSON CLI parity and duplicated stream lifecycle). Spec: 1 finding fixed (Session-log Stop access). Each behavioral finding's exact reproduction was run before deciding, failed as reported, and passes after the fix; regressions are retained.Both axes read all 27 changed files, including the final follow-up. Unread changed files: none. Generated-output exclusions: none.
Unaddressed findings
Merge Danger
Door: two-way
No migration. Reverting restores the previous Console and CLI behavior.
Blast Radius: Console
Signed-in accounts can Stop live Commands through confirmation and CSRF protection. Signaling, process identity checks, child-Run refusal and cleanup use the existing CLI implementation. The CLI gains an optional JSON completion format.
Built with codex · gpt-6.1-sol · high