Skip to content

Stop live Commands from the Console - #869

Merged
JacobStephens2 merged 5 commits into
issue-776from
issue-823
Oct 20, 2026
Merged

JacobStephens2 merged 5 commits into
issue-776from
issue-823

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Summary

Live Commands can now be stopped from their Console details, including while reading a Session log.

Stop → confirm + CSRF → shared CLI Stop (Console + account email)
                         ├─ Stop: needs-triage
                         └─ Requeue instead: ready-for-agent
push → still ending + stopping bar → outcome + work left on origin

Closes #823

Evidence

  • Before: the real-Command HTTP regression failed because Details had no Stop control.
    After: cargo test --test console console_stop_confirms -- --nocapture verifies authentication, CSRF, confirmation, triage/requeue labels against fake GitHub, attribution, pushed completion and retained work with a waiting fake Harness.
  • Before: a live Session reader's Command details returned HTTP 404.
    After: python3 console/reproductions/session-stop.py returns HTTP 200 with Stop; Playwright follows the live Session's link.
  • Before: stop --json was rejected, conflicting with ADR 0016.
    After: cargo test --test stop json_stop_reports -- --nocapture checks the outcome, retained work and labels for both endings. Both Stop routes list JSON CLI equivalents in the parity test.
  • cargo test --locked, cargo fmt --check, cargo clippy --all-targets -- -D warnings, and all 27 Console Playwright tests pass. Browser checks cover cancellation, both confirmation choices, reduced motion, pushed outcomes and removal of stale Stop controls.

Test seams:

  • Console HTTP routes, authenticated forms and push notices against a real Command, waiting fake Harness and fake GitHub.
  • Console browser interaction through Playwright, including confirmation, cancellation and pushed completion.
  • CLI Stop behavior, JSON completion output and route-to-CLI parity.

Review coverage

Reviewed against issue-776 pinned at 7788650 using independent Standards and Spec reviewers. Standards: 2 findings fixed (JSON CLI parity and duplicated stream lifecycle). Spec: 1 finding fixed (Session-log Stop access). Each behavioral finding's exact reproduction was run before deciding, failed as reported, and passes after the fix; regressions are retained.

Both axes read all 27 changed files, including the final follow-up. Unread changed files: none. Generated-output exclusions: none.

Unaddressed findings

  • Standards: none.
  • Spec: none.

Merge Danger

Door: two-way

No migration. Reverting restores the previous Console and CLI behavior.

Blast Radius: Console

Signed-in accounts can Stop live Commands through confirmation and CSRF protection. Signaling, process identity checks, child-Run refusal and cleanup use the existing CLI implementation. The CLI gains an optional JSON completion format.

Built with codex · gpt-6.1-sol · high

Preserve Console Stop and Requeue alongside email-code password setup. Register both sets of routes and HTTP tests, retaining shared-path CLI parity accounting.

Validation: cargo test --locked; cargo clippy --all-targets -- -D warnings; cargo fmt --check; all 27 Console browser tests.
Preserve the Console installation entry alongside the expanded Console Stop implementation and test references.
@JacobStephens2
JacobStephens2 merged commit ddba37f into issue-776 Oct 20, 2026
19 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-823 branch October 20, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant