Repository navigation
Set Console passwords by email code - #868
Merged
Merged
Conversation
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One Set your password flow creates a Console account or resets its password. Codes last 15 minutes with 5 tries; durable limits allow one send a minute and 10 per rolling day. Without a Resend key, the page explains
thirdshift console password.Closes #822
Evidence
After: the same retained regression passes after separating the answer from delivery.
cargo clippy --all-targets -- -D warnings,cargo fmt --check; all 32 Console HTTP tests and 25 Console browser tests, plus the account browser test rerun after the page-rendering refactor.cargo testrun stopped at the existingprocess_tree::interrupting_a_codex_run_stops_a_command_in_its_own_sessioneight-second timing assertion. The exact test passed on rerun in 2.40 seconds. The complete process-tree target and every remaining target then passed in a separate Cargo run; no process-interruption source or tests changed in this PR. All Rust test targets have passing results across these runs.Testing seams: Console HTTP with the compiled binary and Resend stand-in; the shared Accounts interface with controlled time and an external email sender; Console CLI password/log commands; browser sign-in/sign-out. Durable account-file inspection checks the required hash-only storage and verified flag. HTTP expiry/day-limit tests prepare aged durable input with the server stopped.
Merge Danger
Door: two-way
Blast Radius: accounts
Changes Console password setup and shared anonymous-page rendering. Account data gains defaulted verification/code fields; existing password sign-in and CLI account management stay covered.
Review coverage
Independent Standards and Spec reviews used fetched
issue-776pinned at77886506f6fb76ec5797f2a0c6de64559e7f7047. Both read all 12 changed files. No generated-output exclusions and no unread changed files. Standards' duplication finding and Spec's timing and HTTP-coverage findings were addressed.Unaddressed findings
Standards
None.
Spec
None.
Built with codex · gpt-6.1-sol · high