Repository navigation
Keep the Console Inbox live - #855
Merged
Merged
Conversation
Preserve the live Inbox alongside the Console log inventory and readers. Keep stable row identities, heartbeat observations, CLI route parity, and shutdown of both Inbox and log streams during binary replacement. Validated with cargo check --locked, cargo test --locked, cargo fmt --check, cargo clippy --all-targets -- -D warnings, and all 14 Console browser tests.
Preserve live Inbox updates alongside History, Security, exact peeks and keyboard navigation. Keep selection and folds across pushes, and retain both branches' regression coverage.
Preserve live Inbox routing while adding Lanes and Stages navigation. Register both new pages with the existing typed route dispatch and retain both branches' regression coverage.
Preserve live Inbox event routing and typed dispatch while integrating Waterfall navigation and both CLI parity commands. Retain both branches' regression coverage. Validated with cargo check --locked --all-targets, cargo test --locked, cargo fmt --check, cargo clippy --locked --all-targets -- -D warnings, and all 24 Console browser tests.
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Server-observed log growth drives the heartbeat; Silent Runs stay flat.
Needs you drives the tab title and urgent favicon. New Commands are marked
using optional browser storage.
Closes #818
Test seams
Evidence
/eventsreturned 404; the Inbox stayed stale and its title was static.The reviewers' two selection reproductions both failed, and both retained
Playwright regressions failed before the fixes.
stream events, polling, log-growth heartbeat, Silent and reduced motion,
selection/folds/scroll, title/favicon and optional browser storage.
The dispatch reviewer's original reproduction now passes. Logical selection
survives a move into folded Done and regains focus when Done opens.
cargo test --locked,cargo fmt --checkandcargo clippy --all-targets -- -D warningspass on the final tree.The Rust suite includes 1,065 passing unit tests (two ignored) and all
integration tests.
macOS tests are still running or queued.
Review
Reviewed against
issue-776at37b87deusing independent Standards and Specreviewers. Standards: one small duplication fixed. Spec: both selection
findings reproduced and fixed, with regression tests retained.
After the review follow-ups,
src/console.rsreceived a test-only adjustmentto measure CLI parity after attaching Axum router state. Both parity guard
tests pass.
All 14 changed files were read by both reviewers. No changed files were left
unread, and no generated-output exclusions were used.
Merge Danger
Door: two-way
Blast Radius: Console
Unaddressed findings
Standards
None. S1's duplicated log-length parsing now uses one helper.
Spec
None. Both dispatch identity and selection in folded sections were fixed.
Built with codex · gpt-6.1-sol · high