-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Implement BibEntryResource — Fixes #13588 #14292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @UserEstrella!Thank you for contributing to JabRef! Your help is truly appreciated ❤️. We have automatic checks in place, based on which you will soon get automated feedback if any of them are failing. We also use TragBot with custom rules that scans your changes and provides some preliminary comments, before a maintainer takes a look. TragBot is still learning, and may not always be accurate. In the "Files changed" tab, you can go through its comments and just click on "Resolve conversation" if you are sure that it is incorrect, or comment on the conversation if you are doubtful. Please re-check our contribution guide in case of any other doubts related to our contribution workflow. |
|
Error BibEntryResource.java is not recognized in Server.java |
|
JBang build not passing, don't recognize BibEntryResource, need to fix structure and retry |
In order for jbang to work you need to add the class to the https://github.com/JabRef/jabref/blob/main/.jbang/JabSrvLauncher.java file as a source |
koppor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also adapt jabsrv/src/test/rest-api.http and try out your new API.
| Gson gson; | ||
|
|
||
| /** | ||
| * At http://localhost:23119/libraries/{id} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, this is comment wrong, we are at the BibEntry resource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your feedback! Do you mean we should create a new specific end-point for the BibEntry resource? Something like this : <http://localhost:23119/librairies/demo/entries/{id}>?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope you already did.
Note: It already worked like this. The only issue was that the methods handling that were nested in the library class.
|
@UserEstrella Please link the in the first possiblity -
|
koppor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, you misunderstood the whole concept of library collecting entries and a single entry.
Methods returning a complete library were moved. This is wrong...
I am a bit upset as your code makes the impression your just want to get the task done instead of learning something.
Example - JavaDoc format inconsitencies - why does the new class use two styles? - If it was in the old code - why not making it consistent?
The JavaDoc comment is for the library
|
I think, this whole task needs to be re-done and each step from the issue description followed. The issue is NOT about adding new features, it is just about refactoring code. |
Hi, thank you for your feedback. We tried to follow each step from the issue description. However, during the refactoring we encountered a difficulty: Because these elements were missing, we attempted an adaptation based on the available methods and the parameters that were being passed, but it is now clear that this was not the correct approach. We would appreciate any clarification on where the expected @path("entries/{entryId}") methods are located in the current codebase, or whether they were removed/renamed, so that we can redo the task properly according to the issue requirements. Thanks again for your guidance. |
Thank you for the close look - it was removed 2 months ago: 968d289 - and added to I found it with using Ctrl+Shift+F and searching for I think, there is nothing left to be done. Please check another issue. Sorry for any inconvenience caused. |

Closes #13588
Summary
This pull request implements the
BibEntryResourceas described in issue #13588.Since the issue was created some time ago, several structural changes occurred in the project. Therefore, some of the initial instructions were no longer applicable, and adjustments were made accordingly.
Changes Made
jabsrvmodule.jabref/jabsrv/src/main/java/org/jabref/http/server/resources/BibEntryResource.javaLibraryResource.javathat contained the@PathParam("id")parameter — except the one annotated with@Path("entries/pdffiles")— intoBibEntryResource.java.LibraryResourcethat were required for these methods to work properly.startServer()method in theServerclass to include a reference to the newBibEntryResource.jabref/jabsrv/src/test/java/org/jabref/http/server/BibEntryResourceTest.java,based on the existing
LibraryResourceTest.java.Steps to test
To verify the implementation:
jabgui).Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)