Skip to content

Conversation

@palukku
Copy link
Member

@palukku palukku commented Nov 10, 2025

Closes palukku#32

Adds the ability to ctrl + click on a linked pdf if the path is absolute and opens it in vscode (if pdf preview extension is installed)

Steps to test

Start JabLs from this branch and than vscode with the extension enabled.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@palukku palukku changed the title add pdf opening ability Feat: Add the ability to open linked pdf files in bib files Nov 10, 2025
@palukku palukku marked this pull request as draft November 10, 2025 10:02
@palukku
Copy link
Member Author

palukku commented Nov 10, 2025

sorry for force pushing, but I accidentally re ordered a commit in gitbutler and than reversed it to the original state, but because of gitbutlerapp/gitbutler#10266 I needed to force push in order to get it working...

@palukku palukku marked this pull request as ready for review November 10, 2025 11:26
@palukku palukku requested a review from koppor November 10, 2025 11:26
InAnYan
InAnYan previously approved these changes Nov 10, 2025
Copy link
Member

@InAnYan InAnYan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that with absolute paths it works.

Though, from the UI side, I don't like, that it underscores only a single word, not a full URL, but for now ça suffit

@palukku
Copy link
Member Author

palukku commented Nov 10, 2025

Though, from the UI side, I don't like, that it underscores only a single word, not a full URL, but for now ça suffit

But this is from VSCodes side, i set the range for the link to the whole file. The hyperlink view only works for documentLinks, maybe it could be reworked to use DocumentLinks

@InAnYan
Copy link
Member

InAnYan commented Nov 21, 2025

What's the status of this PR? Is it finished, you're working on new review comments?

@github-actions github-actions bot removed the status: changes-required Pull requests that are not yet complete label Nov 25, 2025
@palukku palukku added the status: changes-required Pull requests that are not yet complete label Nov 25, 2025
@github-actions github-actions bot removed the status: changes-required Pull requests that are not yet complete label Nov 27, 2025
koppor
koppor previously approved these changes Nov 27, 2025
koppor
koppor previously approved these changes Nov 27, 2025
@koppor koppor enabled auto-merge November 27, 2025 12:34
@koppor koppor mentioned this pull request Nov 27, 2025
2 tasks
koppor
koppor previously approved these changes Nov 27, 2025
koppor
koppor previously approved these changes Nov 27, 2025
koppor
koppor previously approved these changes Nov 27, 2025
@Siedlerchr
Copy link
Member

FileFieldParser fails
Test [32] [ParsedFileField{description='', link='C:/Users/Philip/Downloads/corti-et-al-2009-cocoa-and-cardiovascular-health.pdf', fileType=''}], ":C:/Users/Philip/Downloads/corti-et-al-2009-cocoa-and-cardiovascular-health.pdf:PDF"[red[] FAILED

org.opentest4j.AssertionFailedError: expected: <[ParsedFileField{description='', link='C:/Users/Philip/Downloads/corti-et-al-2009-cocoa-and-cardiovascular-health.pdf', fileType=''}]> but was: <[ParsedFileField{description='', link='C/', fileType='/Users/Philip/Downloads/corti-et-al-2009-cocoa-and-cardiovascular-health.pdf', sourceUrl='PDF'}]>
    at app/org.jabref.jablib/org.jabref.logic.importer.util.FileFieldParserTest.stringsToParseTest(FileFieldParserTest.java:234)

@koppor koppor added this pull request to the merge queue Nov 27, 2025
Merged via the queue into JabRef:main with commit cbb4d1f Nov 27, 2025
49 checks passed
@koppor koppor deleted the add-pdf-open branch November 27, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open attached PDF

5 participants