-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Open linked pdf files in bib files #14275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jablib/src/main/java/org/jabref/logic/importer/util/FileFieldParser.java
Outdated
Show resolved
Hide resolved
jabls/src/main/java/org/jabref/languageserver/util/definition/BibDefinitionProvider.java
Show resolved
Hide resolved
6bb6c17 to
8d07104
Compare
|
sorry for force pushing, but I accidentally re ordered a commit in gitbutler and than reversed it to the original state, but because of gitbutlerapp/gitbutler#10266 I needed to force push in order to get it working... |
InAnYan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that with absolute paths it works.
Though, from the UI side, I don't like, that it underscores only a single word, not a full URL, but for now ça suffit
But this is from VSCodes side, i set the range for the link to the whole file. The hyperlink view only works for documentLinks, maybe it could be reworked to use DocumentLinks |
|
What's the status of this PR? Is it finished, you're working on new review comments? |
|
FileFieldParser fails |
Closes palukku#32
Adds the ability to ctrl + click on a linked pdf if the path is absolute and opens it in vscode (if pdf preview extension is installed)
Steps to test
Start JabLs from this branch and than vscode with the extension enabled.
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)