feat: structure PostgreSQL ARRAY and column storage options - #2704
Merged
manticore-projects merged 1 commit intoSep 25, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL ARRAY type spelling and column STORAGE EXTENDED were rejected, while accepted storage/compression clauses remained raw column tokens. Qualified types could also flatten array suffixes into the type name.
Keep ARRAY dimensions on ColDataType, retain structured suffixes for qualified names, and model STORAGE/COMPRESSION as mutable ColumnOption kinds shared by CREATE TABLE and ALTER TABLE ADD COLUMN. Preserve bracket arrays, MySQL column storage locations and the established MySQL CAST(... AS ... ARRAY) type-name API.
Validation: full Gradle check and grammar ambiguity gate; dimensions, qualified types, option removal/replacement, both printers and reparsing. All 20 audited ARRAY/storage inputs execute successfully and retain column catalog metadata on PostgreSQL 18.6.