Skip to content

fix(signals): classify Dart protobuf stubs as generated#3412

Merged
gittensory-orb[bot] merged 1 commit into
JSONbored:mainfrom
jimcody1995:fix/path-matchers-pb-dart-generated
Jul 5, 2026
Merged

fix(signals): classify Dart protobuf stubs as generated#3412
gittensory-orb[bot] merged 1 commit into
JSONbored:mainfrom
jimcody1995:fix/path-matchers-pb-dart-generated

Conversation

@jimcody1995

Copy link
Copy Markdown
Contributor

Summary

  • Extend isGeneratedFile in path-matchers.ts to treat .pb.dart as protoc-generated output, matching the existing .pb.go/.pb.swift/.pb.cc handling.
  • The Dart protoc plugin emits messages.pb.dart stubs; without this, classifyChangedFile miscounted them as substantive source (hand-written .dart is unaffected — the .pb infix is required).

Scope

  • Conventional Commit title format.
  • Focused — path-matchers + unit tests only.
  • Follows CONTRIBUTING.md.
  • No linked issue needed.

Validation

  • git diff --check
  • npm run test:ci on Node 22
  • npm audit --audit-level=moderate — 0 vulnerabilities
  • Unit test covers proto/messages.pb.dart as generated and lib/user.dart as non-generated

Safety

  • No secrets, auth, or UI changes.
  • N/A for UI Evidence.

UI Evidence

N/A — backend path classifier only.

Notes

Conflict avoidance: Touches only src/signals/path-matchers.ts and test/unit/path-matchers.test.ts. Zero overlap with open PRs (#3408/#3406 engine, #3407 enrichment tests, #3379 selfhost, #3314 miner, #3305 enrichment-wire, #3304 queue/gate). Merges cleanly after any of those land without rebase.

Made with Cursor

protoc's Dart plugin emits .pb.dart message stubs; slop already
treated .pb.go/.pb.swift as generated but missed .pb.dart, so
machine output was miscounted as substantive source.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jimcody1995 jimcody1995 requested a review from JSONbored as a code owner July 5, 2026 06:32
@superagent-security

Copy link
Copy Markdown

Superagent didn't find any vulnerabilities or security issues in this PR.

@gittensory-orb gittensory-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.5x multiplier. label Jul 5, 2026
@gittensory-orb

gittensory-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 06:36:39 UTC

2 files · 1 AI reviewer · no blockers · readiness 80/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This narrowly extends the generated-file matcher so Dart protobuf stubs like `proto/messages.pb.dart` take the same generated path as existing protobuf outputs, while ordinary Dart source still stays out because the `.pb.` infix is required. The implementation is at the right layer for `classifyChangedFile`, since that path delegates to `isGeneratedFileFrom`, and the added unit test exercises the new suffix without broadening hand-written `.dart` matches. I do not see a reachable correctness issue in this diff.

Nits — 3 non-blocking
  • nit: `test/unit/path-matchers.test.ts:76` now says "Swift protobuf, Dart freezed/retrofit" but the case also covers Dart protobuf, so rename the test to reflect the new assertion.
  • `test/unit/path-matchers.test.ts:76` should be renamed to something like `matches Swift/Dart protobuf, Dart build_runner, and C# designer/XAML codegen` so the test title stays aligned with the cases it owns.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ No-issue rationale PR body explains why no issue is linked.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 58 registered-repo PR(s), 31 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor jimcody1995; Gittensor profile; 58 PR(s), 0 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: jimcody1995
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 58 PR(s), 0 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@gittensory-orb gittensory-orb Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@gittensory-orb gittensory-orb Bot merged commit c130490 into JSONbored:main Jul 5, 2026
6 checks passed
@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.46%. Comparing base (01844a4) to head (441215d).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3412   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files         290      290           
  Lines       30789    30789           
  Branches    11221    11221           
=======================================
  Hits        28778    28778           
  Misses       1355     1355           
  Partials      656      656           
Files with missing lines Coverage Δ
src/signals/path-matchers.ts 88.46% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.5x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant