fix(signals): classify Dart protobuf stubs as generated#3412
Conversation
protoc's Dart plugin emits .pb.dart message stubs; slop already treated .pb.go/.pb.swift as generated but missed .pb.dart, so machine output was miscounted as substantive source. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-05 06:36:39 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 3 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3412 +/- ##
=======================================
Coverage 93.46% 93.46%
=======================================
Files 290 290
Lines 30789 30789
Branches 11221 11221
=======================================
Hits 28778 28778
Misses 1355 1355
Partials 656 656
🚀 New features to boost your workflow:
|
Summary
isGeneratedFileinpath-matchers.tsto treat.pb.dartas protoc-generated output, matching the existing.pb.go/.pb.swift/.pb.cchandling.messages.pb.dartstubs; without this,classifyChangedFilemiscounted them as substantive source (hand-written.dartis unaffected — the.pbinfix is required).Scope
CONTRIBUTING.md.Validation
git diff --checknpm run test:cion Node 22npm audit --audit-level=moderate— 0 vulnerabilitiesproto/messages.pb.dartas generated andlib/user.dartas non-generatedSafety
UI Evidence
N/A — backend path classifier only.
Notes
Conflict avoidance: Touches only
src/signals/path-matchers.tsandtest/unit/path-matchers.test.ts. Zero overlap with open PRs (#3408/#3406 engine, #3407 enrichment tests, #3379 selfhost, #3314 miner, #3305 enrichment-wire, #3304 queue/gate). Merges cleanly after any of those land without rebase.Made with Cursor