Skip to content

fix(enrichment): treat .python-version as a Python runtime pin for EOL checks#3113

Merged
gittensory-orb[bot] merged 1 commit into
JSONbored:mainfrom
bohdansolovie:fix/eol-python-version-pin
Jul 4, 2026
Merged

fix(enrichment): treat .python-version as a Python runtime pin for EOL checks#3113
gittensory-orb[bot] merged 1 commit into
JSONbored:mainfrom
bohdansolovie:fix/eol-python-version-pin

Conversation

@bohdansolovie

Copy link
Copy Markdown
Contributor

Summary

The EOL analyzer and its scheduler runtime-pin gate recognized Node pin files (.nvmrc, .node-version) but not pyenv/asdf's .python-version. PRs that pin Python that way silently skipped EOL analysis.

Scope

  • extractVersionPins treats .python-version as product python (same leading-version format as .nvmrc).
  • isRuntimePinPath in the scheduler admits .python-version so the gate cannot skip a file the analyzer would parse.

Test plan

  • extractVersionPins on .python-version with 3.11.0{ product: "python", version: "3.11.0" }.
  • node --test test/eol-check.test.ts — 10 passed.
  • Analyzer metadata check clean.

No linked issue

Self-contained detection-coverage fix; no tracking issue. Touches eol-check.ts, scheduler.ts, and the eol test.

Made with Cursor

…L checks

The EOL analyzer and its scheduler gate recognized Node pin files but not
pyenv/asdf's `.python-version`, so PRs that pin Python that way silently
skipped EOL analysis. Parse `.python-version` as product `python` and admit
it through the runtime-pin gate.

Co-authored-by: Cursor <cursoragent@cursor.com>
@bohdansolovie bohdansolovie requested a review from JSONbored as a code owner July 4, 2026 14:54
@superagent-security

Copy link
Copy Markdown

🚨 Contributor flagged. Click here for more info: Superagent Dashboard

@superagent-security superagent-security Bot added the contributor:flagged Contributor flagged for review by trust analysis. label Jul 4, 2026
@superagent-security

Copy link
Copy Markdown

Superagent didn't find any vulnerabilities or security issues in this PR.

@gittensory-orb gittensory-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.5x multiplier. label Jul 4, 2026
@gittensory-orb

gittensory-orb Bot commented Jul 4, 2026

Copy link
Copy Markdown

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-04 14:53:45 UTC

3 files · 1 AI reviewer · no blockers · readiness 73/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This change correctly adds `.python-version` to both sides of the EOL analyzer wiring: `extractVersionPins` now emits a Python pin from the file, and `isRuntimePinPath` now lets the scheduler run the EOL analyzer when that file changes. The parser uses the same leading-version rule as the existing `.nvmrc`/`.node-version` path, which matches pyenv/asdf runtime pins and keeps the analyzer/gate behavior aligned. CI is green and I do not see a reachable correctness defect in the provided diff.

Nits — 5 non-blocking
  • nit: `review-enrichment/src/analyzers/eol-check.ts:56` has a stale function comment that still lists only `Dockerfile / .nvmrc / go.mod`; update it to include `.node-version` and `.python-version` so the parser contract matches the implementation.
  • nit: `review-enrichment/test/eol-check.test.ts:51` covers the parser path for `.python-version`, but there is no visible scheduler test proving `isRuntimePinPath` admits `.python-version`; add one if scheduler gating has nearby coverage to prevent analyzer/gate drift from returning.
  • Update the `extractVersionPins` doc comment in `review-enrichment/src/analyzers/eol-check.ts` to name all supported pin files, including `.python-version`.
  • Add or extend scheduler gating coverage around the EOL analyzer so a PR changing only `.python-version` is not skipped with `no_runtime_pin`.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 127 registered-repo PR(s), 58 merged, 10 issue(s).
Contributor context ✅ Confirmed Gittensor contributor bohdansolovie; Gittensor profile; 127 PR(s), 10 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: bohdansolovie
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 127 PR(s), 10 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Explain no-issue PR.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@gittensory-orb gittensory-orb Bot added the gittensor Gittensor contributor context label Jul 4, 2026

@gittensory-orb gittensory-orb Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@gittensory-orb gittensory-orb Bot merged commit 53ff030 into JSONbored:main Jul 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor:flagged Contributor flagged for review by trust analysis. gittensor:bug Gittensor-scored bug fix — scores a 0.5x multiplier. gittensor Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant