Repository navigation
Rails 7.0 to 8.1 and Ruby 3.4 support for release-0-9 - #1501
Open
MichalBryxi wants to merge 5 commits into
Open
MichalBryxi wants to merge 5 commits into
MichalBryxi wants to merge 5 commits into
Conversation
The request parser and resources use CSV, which Ruby 3.4 no longer loads without it being in the bundle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QduxfgWotKixa3ehszsbf2
Rails 7.2 removed ActiveSupport::Deprecation.warn, so declaring an id attribute or a belongs_to raised NoMethodError. An ActiveSupport::Deprecation instance works on every Rails the gem supports. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QduxfgWotKixa3ehszsbf2
- Initialize the test app before rails/test_help, which reads the application's config while loading from Rails 7.1. - schema_format :none is gone from Rails 8.0; no schema is dumped instead. - represent_boolean_as_integer only exists on Rails 5.2. - fixture_path= became fixture_paths= (7.1) and was removed (7.2). - Forward keyword arguments to process/get explicitly (Ruby 3). - t.references never took a references: option; Rails 7.1 rejects it. - Pin minitest to 5: minitest 6 moved minitest/mock out. - Rails 8 needs sqlite3 >= 2.1. - Accept the json gem's newer parse error wording. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QduxfgWotKixa3ehszsbf2
Keeps Rails 5.1 to 6.1 on Ruby 2.6 and 2.7, and runs on ubuntu-22.04, which setup-ruby still has Ruby 2.6 and 2.7 for. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QduxfgWotKixa3ehszsbf2
Rack 3.1 renamed :unprocessable_entity to :unprocessable_content and warns on the old name, which older Racks don't know. The number works on both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QduxfgWotKixa3ehszsbf2
This was referenced Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the 0.9 line run, and its own suite pass, on Rails 7.0 through 8.1 and Ruby 3.2 and 3.4, without dropping any Rails or Ruby the CI tests today.
release-0-9already has the Rack 3 fix (#1462) and the Rails 8.1 routing backport (#1497), so routing and status codes already worked. What remained:Library
ActiveSupport::Deprecation.warnwas removed in Rails 7.2, soattribute :idandbelongs_toraisedNoMethodError. They now warn throughJSONAPI.deprecator, anActiveSupport::Deprecationinstance.csvis a bundled gem from Ruby 3.4, so it's a dependency now.422rather than:unprocessable_entity, which Rack 3.1 renamed and warns about, while older Racks don't know the new name.Tests
rails/test_help. From Rails 7.1,rails/test_helpreads the application's config while it loads.schema_format :none(gone in Rails 8.0),fixture_paths=(7.1+), keyword args forwarded explicitly (Ruby 3), and an invalidt.references ... references:option.CI: an explicit matrix of 18 jobs, from Rails 5.1 on Ruby 2.6 to Rails 8.1 on Ruby 3.4. It runs on
ubuntu-22.04, which still has Ruby 2.6 and 2.7 builds.Verified locally (official
ruby:*Docker images)All 626 tests pass (7561 assertions) on each of:
Fixes #1477 for the 0.9 line. Related: #1479 and #1488 (Rails 8.1 routing, fixed by #1497), #1480 (Rails 7.1+/8 support for
master). A 0.9.13 release from this branch would unblock apps pinned to 0.9 throughjsonapi-authorization(~> 0.9.0).🤖 Generated with Claude Code
https://claude.ai/code/session_01QduxfgWotKixa3ehszsbf2