Repository navigation
fork-release: do not restore target/ from cache - #8
Merged
Merged
Conversation
The first tag run restored a target/ cache in which the v8 build script was fresh but its downloaded static library was absent, and the build failed with "could not find native static library rusty_v8". A release build is a full LTO build regardless, so cache only the cargo registry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first
fork-v0.1.0tag run failed in "Build Codex package" withcould not find native static library rusty_v8. The run restored thetarget/cache saved by the earlier build-only dispatch, in which thev8crate's build script was fresh but its downloaded static library was not part of the cache. Stop cachingtarget/(cache-targets: "false"); keep the cargo registry cache. A release build is a full LTO build regardless, so the target cache bought almost nothing.Test plan
fork-v0.1.0on the merged commit and confirm the tag run publishes the release