Repository navigation
ci: make the fork's PR checks meaningful - #7
Merged
Merged
Conversation
Upstream's CI assumes OpenAI infrastructure (self-hosted runner groups, paid macOS runners, a BuildBuddy cache, signing and publishing secrets, an OpenAI API key for the issue bots). In the fork those jobs fail in seconds or queue forever, so every PR is red for reasons unrelated to the change. - blocking-ci.yml: drop the `bazel` and `sdk` calls and their `required` entries, with a comment explaining why. - rust-ci.yml: the Bazel-backed "Argument comment lint" matrix is upstream-only (`if: github.repository == 'openai/codex'`); `results` accepts it being skipped outside upstream. - scripts/fork-ci-disable.sh: disables, as a repository setting, the workflows that only make sense upstream (post-merge full CI, V8 canary, release and publishing workflows, issue bots, stale-PR sweeper, CLA). - docs/fork-ci.md: what runs, what is off, and how to resolve conflicts on these lines when merging upstream. Also fix the three real findings those checks had surfaced: - verify_cargo_workspace_manifests.py: code-mode no longer declares the `sandbox` feature, so its exception was stale. - core tests: `scenarios_read_only_mcp.rs` is a one-line stub that no module declares (upstream main is in the same state, with the snapshot left behind). Delete the stub and its orphaned snapshot so cargo shear stops flagging an unlinked file. - .codespellignore: `WRONLY` (O_WRONLY) and `oint` (LaTeX \oint).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the fork's PR checks mean something. Upstream's CI assumes OpenAI infrastructure (self-hosted runner groups, paid macOS runners, a BuildBuddy cache, signing/publishing secrets, an OpenAI API key for the issue bots); in the fork those jobs fail in seconds or queue forever, so every PR was red for reasons unrelated to the change.
Pruned, in the workflow files with
Fork:commentsblocking-ci.yml: drop thebazelandsdkcalls and theirrequiredentries.rust-ci.yml: the Bazel-backed "Argument comment lint" matrix is upstream-only (if: github.repository == 'openai/codex');resultsaccepts it being skipped outside upstream.Disabled as a repository setting (already applied with
gh workflow disable;scripts/fork-ci-disable.shrecords the list so it can be re-run after an upstream merge): post-merge full CI, V8 canary, all upstream release/publishing workflows, the issue bots, the stale-PR sweeper, the CLA assistant.Real findings those checks had surfaced, fixed
verify_cargo_workspace_manifests.py: stalecode-modefeature exception.scenarios_read_only_mcp.rsis a one-line stub no module declares (upstream main is in the same state); delete it and its orphaned snapshot so cargo shear is clean..codespellignore:WRONLY(O_WRONLY) andoint(LaTeX\oint).docs/fork-ci.mddocuments what runs, what is off, and how to resolve conflicts on these lines when merging upstream.Test plan
python3 .github/scripts/verify_cargo_workspace_manifests.pypassescodespell --ignore-words=.codespellignorecleancargo shear --deny-warnings: no issuescargo check -p codex-core --testspasses