merge the JCSDA-internal/mpas-bundle into the public repo.#13
Conversation
|
You should look at the CMakeLists.txt changes with 'ignore whitepace' selected.
|
| #TODO: When mpas-bundle becomes a public repo, consider changing the default value of BUNDLE_SKIP_ROPP-UFO to "ON" | ||
| option(BUNDLE_SKIP_ROPP-UFO "Don't build ROPP-UFO" "ON") # Build ropp-ufo unless user passes -DBUNDLE_SKIP_ROPP-UFO=ON | ||
| ecbuild_bundle( PROJECT ropp-ufo GIT "https://github.com/JCSDA-internal/ropp-test.git" BRANCH develop UPDATE ) | ||
| option(BUNDLE_SKIP_RTTOV "Don't build rttov" "ON") # Skip rttov build unless user passes -DBUNDLE_SKIP_RTTOV=OFF | ||
| ecbuild_bundle( PROJECT rttov GIT "https://github.com/JCSDA-internal/rttov.git" BRANCH develop UPDATE ) |
There was a problem hiding this comment.
Should these lines be removed, if possible? The components don't seem to be built by default and building them requires access to JCSDA-internal, which most users may not have.
There was a problem hiding this comment.
I think the comment on line 49 should be deleted.
I think the ability to build ropp should remain, for people (like me:-) who might want to run the ropp tests in the context of a public build. I can easily be persuaded otherwise:-)
@byoung-joo Your thoughts on this?
| module load cuda/12.3.2 | ||
| module load parallel-netcdf/1.14.0 | ||
| module list | ||
|
|
There was a problem hiding this comment.
Do we need to set environment variables at the end of the script, analogous to the GNU and Intel setup scripts? I haven't tested with the nvhpc compilers myself, this comment is just based on a comparison with the other scripts.
There was a problem hiding this comment.
The nvhpc build doesn't need environment variables set. In part because the nvhpc build only builds MPAS-Model; none of the other components get built with the nvhpc compiler.
I have tested this.
| module load cuda/12.3.2 | ||
| module load parallel-netcdf/1.14.0 | ||
| module list | ||
|
|
There was a problem hiding this comment.
Same comment regarding environment variables as in env-setup/nvhpc-derecho.csh
3 participants
TYPE: enhancement
KEYWORDS: release/v4
LIST OF MODIFIED FILES:
M CMakeLists.txt
M README.md
M env-setup/crontab.sh
M env-setup/gnu-derecho.csh
M env-setup/gnu-derecho.sh
M env-setup/intel-derecho.csh
M env-setup/intel-derecho.sh
M env-setup/mpas-bundle-cron.sh
A env-setup/nvhpc-derecho.csh
A env-setup/nvhpc-derecho.sh
M env-setup/run_make.bundle.sh
TESTS CONDUCTED: Built with gnu compiler double precision and all ctests passed