Skip to content

feat(sidebar): recent tables section (opt-in)#2

Closed
J2TeamNNL wants to merge 2 commits into
sidebarfrom
recent-tables
Closed

feat(sidebar): recent tables section (opt-in)#2
J2TeamNNL wants to merge 2 commits into
sidebarfrom
recent-tables

Conversation

@J2TeamNNL
Copy link
Copy Markdown
Owner

Restores the Recent tables section dropped from TableProApp#1422 (commit 4b76452) for separate review, and adds a setting to toggle it.

Changes

  • Restore Recent tables (RecentTablesStore in-memory, last 10 per connection+database, push-on-open, Recent section in the Tables tab, tests, docs, CHANGELOG Favorite tables and recent tables TableProApp/TablePro#1352). Recovered by reverting the removal commit.
  • New setting General > Sidebar > Show recent tables, default OFF. When off the section is hidden and no opens are recorded. Added GeneralSettings.showRecentTables (backward-compatible decode), settings UI toggle, gating in SidebarView and MainContentCoordinator+Navigation, settings docs, and GeneralSettingsTests.

Base

Targets sidebar because the feature depends on the sidebar rework; merge after TableProApp#1422.

Review focus

  1. Nghiep vu: scope per connection+database, cap 10, in-memory only, opt-in default off.
  2. Trai nghiem: vi tri Recent section, hanh vi khi bat/tat setting.

Verification

Build/lint not run here (no Xcode in this env), needs CI. Restored code previously compiled on sidebar; verified TableRow / SidebarContextMenu / RecentTablesStore.Entry signatures still match. New test file is auto-included via the project's synchronized file groups.

@github-actions
Copy link
Copy Markdown

Thank you for your contribution! Before we can merge this PR, you need to sign our Contributor License Agreement.

To sign, please comment below with:

I have read the CLA Document and I hereby sign the CLA.


I have read the CLA Document and I hereby sign the CLA.


Nguyễn Nam Long seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@J2TeamNNL
Copy link
Copy Markdown
Owner Author

Tạo nhầm base (sidebar). Mở lại đúng base main tại #3, đóng PR này.

@J2TeamNNL J2TeamNNL closed this May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant