Skip to content

Download scala-ci's extra binary into the checked-out repo - #178

Merged
skeet70 merged 1 commit into
mainfrom
scala-ci-binary-into-repo
Sep 30, 2026
Merged

skeet70 merged 1 commit into
mainfrom
scala-ci-binary-into-repo

Conversation

@skeet70

@skeet70 skeet70 commented Sep 30, 2026

Copy link
Copy Markdown
Member

scala-ci v2 checks the repo out into scala-repo/ but download_release_binary_* still saved the binary to the workspace root, so tests running in scala-repo/ with LD_LIBRARY_PATH=./ couldn't load it (ironoxide-scala failure). The autofix change check now ignores untracked files, so the downloaded binary doesn't trigger an empty auto-fix commit.

@skeet70
skeet70 requested a review from a team as a code owner September 30, 2026 20:26
@skeet70
skeet70 requested review from coltfred and removed request for a team September 30, 2026 20:26
@github-actions

Copy link
Copy Markdown

Merging this PR will move these workflow tags:

scala-ci-v2.0.0

@github-actions

Copy link
Copy Markdown

File Coverage Lines
All files 66% 66% ✅

Minimum allowed coverage is 24%

Generated by 🐒 cobertura-action against 34dcc0d

@skeet70
skeet70 merged commit e67e5ca into main Sep 30, 2026
13 checks passed
@skeet70
skeet70 deleted the scala-ci-binary-into-repo branch September 30, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants