You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
complete the AUv2 audio render, lifecycle, property, bypass, tail, latency, state, and Cocoa editor paths
implement AUv2 MIDI input (MIDIEvent, SysEx, StartNote, StopNote) with bounded queues and sample offsets
implement AUv2 MIDI output callback/property support without locks or allocations on the render path
turn the sine example into a real aumu instrument and add a LaunchServices-based macOS host smoke test
add pinned CodeQL and optimize the existing build, test, and docs workflows
pin the compatible public Intrect-io/iced_baseview revision needed by the existing baseview fork
Why
The fork had an incomplete AU wrapper: host audio behavior and several AU properties/lifecycle contracts were missing, MIDI selectors and output callbacks were not wired, and the existing CLI-only validation could not prove component discovery or render behavior on current macOS. The iced editor also depended on an iced_baseview revision incompatible with the pinned baseview ABI.
Impact
AU instruments can receive MIDI, render audio, and emit MIDI through the legacy AUv2 host contract.
MIDI queues are bounded, timing is clamped per render block, and callback replacement does not block the audio thread.
The smoke harness verifies the packaged component through an actual .app host and restores any pre-existing installed component.
CI action references are SHA-pinned, cache keys are deterministic, and CodeQL covers Actions and Rust.
Validation
cargo test --locked --workspace --features 'simd,standalone,zstd'
cargo test --locked --lib --features 'au,vst3,zstd' — 119 passed
release library tests — 108 passed
no-default-feature build and pinned-nightly docs build passed
macOS universal package build passed for all 12 example packages; AU binaries verified as arm64 + x86_64
🔍 Fresh review of 0371317 (openswarm pr review --fresh)
✓ Decision: APPROVE
No material correctness or production-wiring defect found. AU MIDI selector dispatch, queueing, callback output, bundle metadata, example export, and macOS smoke-test wiring are present and mutually consistent.
🔍 Fresh review of 63f2913 (openswarm pr review --fresh)
✎ Decision: REVISE
The AU MIDI-output callback storage has an unbounded per-instance memory leak when a host replaces its callback. Other reviewed MIDI production wiring is present, including selector dispatch and the macOS smoke host.
🔍 Fresh review of 971d26c (openswarm pr review --fresh)
✓ Decision: APPROVE
The AU MIDI path is wired from MusicDevice selectors through bounded render-time queues into ProcessContext and back through the AU MIDI-output callback. The smoke host exercises component discovery, rendering, basic MIDI I/O, SysEx acceptance, extended start/stop notes, LastRenderError, and TailTime. No concrete correctness defect found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
MIDIEvent,SysEx,StartNote,StopNote) with bounded queues and sample offsetsaumuinstrument and add a LaunchServices-based macOS host smoke testIntrect-io/iced_baseviewrevision needed by the existing baseview forkWhy
The fork had an incomplete AU wrapper: host audio behavior and several AU properties/lifecycle contracts were missing, MIDI selectors and output callbacks were not wired, and the existing CLI-only validation could not prove component discovery or render behavior on current macOS. The iced editor also depended on an
iced_baseviewrevision incompatible with the pinned baseview ABI.Impact
.apphost and restores any pre-existing installed component.Validation
cargo test --locked --workspace --features 'simd,standalone,zstd'cargo test --locked --lib --features 'au,vst3,zstd'— 119 passedarm64+x86_64scripts/au_midi_smoke.shpassed component discovery, bus layout, pre-note silence, note-on audio, note-off, SysEx, Start/StopNote, MIDI output echo,LastRenderError, and infinite tail checksStack
This draft targets
aud-747-audit-fixes(PR #2) so the AUD-834 diff stays isolated. Retarget it tomasterafter PR #2 lands.Linear: AUD-834