Vanrossem integration: dep bumps + stubs#3
Open
Jimbo4350 wants to merge 6 commits into
Open
Conversation
Jimbo4350
force-pushed
the
jmillar/vanrossem-integration
branch
from
e55ebb7 to
9eab27d
Compare
Jimbo4350
force-pushed
the
jmillar/vanrossem-integration
branch
from
9eab27d to
e0a078c
Compare
Jimbo4350
force-pushed
the
jmillar/vanrossem-integration
branch
3 times, most recently
from
3666e00 to
39c71f6
Compare
Open the listening socket ourselves (with SO_REUSEADDR) and close it in a bracket around Warp.runSettingsSocket rather than letting Warp.runSettings manage it. The close then runs on every exit path, including async cancel, so the port is freed before the next e2e stage rebinds it; fixes intermittent EADDRINUSE when kupo is restarted on the same port.
Set managerIdleConnectionCount = 0 so each request opens a fresh connection. The e2e tests restart kupo on the same port between stages, and reusing a connection pooled from the previous instance caused intermittent failures.
…anager Same fix as the e2e manager (managerIdleConnectionCount = 0) so the state-machine suite never reuses a connection pooled from a prior kupo instance on the same port.
Jimbo4350
force-pushed
the
jmillar/vanrossem-integration
branch
from
49f043e to
c2a5b09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO vanrossemfor follow-up.Mechanical (no behavior change):
Transaction.hs: switch toLedger.Tx Ledger.TopTx <Era>(newTxLevelkind onTx);getTransactionIdnow usesLedger.txIdTx @<Era>directly.Cardano.hs:Ledger.fromTxSeq txs→txs ^. Ledger.txSeqBlockBodyL.Stubbed (revisit before merging to master):
Script.hs—Ledger.Alonzo.TimelockScriptconstructor removed; all native-script paths +mkBinaryPlutusScript(era kind change) stubbed.Metadata.hs—translateAlonzoTxAuxData/upgradeTxAuxDataremoved;fromAlonzoMetadata/fromBabbageMetadatastubbed.Point.hs—ouroboros-networknow ships an overlappingToJSON (Point block)instance; local instance removed. JSON output shape needs verification.MonadOuroboros.hs—Ouroboros.Network.NodeToClientno longer exists in ouroboros-network 1.1; broken imports stripped,NodeToClientVersionkept as a local placeholder,withChainSyncServerbody iserror "TODO".Hydra.hs—decodePartialTransactionfails with a TODO (newTxLevelparameter made thedecCBORcall ambiguous).Test plan
cabal build all -j4— green locally (lib + test + exe link).TODO vanrossemagainst the new cardano-ledger / ouroboros-network APIs.-Wincomplete-patternsinKupo.Data.Cardano.foldBlock(production build uses-Werror).