-
Notifications
You must be signed in to change notification settings - Fork 50
complete omics KG build #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…rence-backend feat: add inference backends
…robs fix: fix loss_entropy
* feat: add config and operator node types * refactor: refactor readers with ray data * fix: delete param parallelism for readers * fix: fix import error * refactor read and chunk operators with no side effects * fix: fix import error * fix: fix return logic * refactor: rename operator split to chunk * refactor: refactor build_kg to accomodate ray data * feat: add StorageFactory & global params * refactor: refactor quiz to accomodata ray data engine * fix: reload graph before quizzing * Potential fix for pull request finding 'Unreachable code' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * fix: fix quiz params * refactor: refactor quiz&judge to ray actors * fix: fix transferring quizzed data to JudgeService * refactor: refactor partition to accomodate ray data * fix: fix lint problem * refactor: refactor op generate * feat: write results in output folder * fix: raise error when no dataset is created * fix: return generator in ece_partitioner * fix: return generator in ece_partitioner * refactor: refactor data format to support multi-modal input * fix: delete fetching schema to avoid ray's duplicate execution * fix: fix operators' registry * feat: refactor schema_guided_extraction & add examples * feat: seperate ray logs and service logs * feat: use storage actor * feat: add kuzu graph database * feat: add llm as actors * refactor: delete old runner * fix: fix vllm wrapper * docs: update .env.example * fix: use kuzudb in quiz_service * fix: update webui * feat: make storage backend configuragble * docs: update README” --------- Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
… Ray Data architecture with protein QA features
…er (InternScience#117) * fix: fix data type of num_gpus & generate_topk_per_token of vllmwrapper * fix: fix lint error
Summary of ChangesHello @CHERRY-ui8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a major enhancement by introducing a comprehensive framework for multi-omics knowledge graph construction and question-answer generation. It enables users to process DNA, RNA, and protein data through a unified pipeline, leveraging both online biological databases and efficient local BLAST searches. The changes streamline the workflow for bioinformatics tasks, making it easier to extract structured knowledge and generate relevant QA pairs from complex biological information. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This is an impressive and substantial pull request that introduces a complete multi-omics knowledge graph generation pipeline. The refactoring of the search operators, configuration management, and asynchronous handling is excellent and greatly improves the robustness and user experience of the codebase. The new features are well-documented in the added README file. I have a few suggestions to further enhance correctness and maintainability.
9f3c59e to
741ebd3
Compare
…ne ID access in NCBISearch
36bb6be to
7d86271
Compare
…sted formatting in `base_operator.py`, `base_searcher.py`, and `anchor_bfs_partitioner.py` for consistency. Removed unnecessary blank lines in `json_reader.py`, `rnacentral_searcher.py`, and other template files to improve readability.
52c23f0 to
f747270
Compare
ecae957 to
57faab0
Compare
No description provided.