Skip to content

[Enhance] Add _collect_full_state_dict in BaseModel #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HAOCHENYE wants to merge 1 commit into
base: gh/HAOCHENYE/14/base
Choose a base branch
from
Open

[Enhance] Add _collect_full_state_dict in BaseModel #1469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions xtuner/v1/model/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
from torch.distributed.device_mesh import DeviceMesh, init_device_mesh
from torch.distributed.fsdp import (
CPUOffloadPolicy,
FSDPModule,
MixedPrecisionPolicy,
fully_shard,
)
Expand Down Expand Up @@ -1514,3 +1515,13 @@ def _init_world_mesh(self):
# TODO: Support hsdp_sharding_size
fsdp_mesh = init_device_mesh(device, (world_size,))
return fsdp_mesh

def _collect_full_state_dict(self, module: nn.Module):
assert isinstance(module, (nn.Module, FSDPModule))

ret = {}
for name, param in module.state_dict().items(): # type: ignore[attr-defined]
if isinstance(param, DTensor):
param = param.full_tensor()
ret[name] = param
return ret