[InternalMetrics][Fix] fix dummy_fwd && refactor code && add CI #1468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR involves several improvements for internal metrics:
torch.autograd.gradinstead oftorch.func.grad_and_value, which requires loss calculation to be performed on require-grad tensors. The original dummy forward in internal metrics monitor would perform loss calculation inno_gradmode, causing a runtime error. This PR removes unnecessary loss_ctx to avoid this.