Skip to content

fix rl_trainer train_metrics global_step and add avg train_metrics #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
YanhuiDua wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix rl_trainer train_metrics global_step and add avg train_metrics #1465

YanhuiDua wants to merge 2 commits into from

Conversation

@YanhuiDua
Copy link
Collaborator

@YanhuiDua YanhuiDua commented Jan 30, 2026

No description provided.

HAOCHENYE
HAOCHENYE reviewed Jan 30, 2026
View reviewed changes
Copy link
Collaborator

@HAOCHENYE HAOCHENYE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

後続で PR を提出して train_step のロジックを整理し、ログ関連のコードを抽出することを提案します。現在の内容が多すぎて、重要なコードが見つからなくなっています。

xtuner/v1/train/rl_trainer.py
mini_batch_metrics.setdefault(k, []).append(cast(float, v))

for key, value in mini_batch_metrics.items():
avg_value = sum(value) / len(value)
Copy link
Collaborator

@HAOCHENYE HAOCHENYE Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

の値が空のリストになる可能性はあり、0除算エラーが発生することはありますか

Copy link
Collaborator Author

@YanhuiDua YanhuiDua Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, done

@YanhuiDua
Copy link
Collaborator Author

YanhuiDua commented Jan 30, 2026

後続で PR を提出して train_step のロジックを整理し、ログ関連のコードを抽出することを提案します。現在の内容が多すぎて、重要なコードが見つからなくなっています。

是的 ，后面rl trainer考虑单独处理日志

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HAOCHENYE HAOCHENYE HAOCHENYE left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@YanhuiDua @HAOCHENYE