refactor(pytorch): replace backend operator builders with typed build specs - #4890
Draft
grimoire wants to merge 12 commits into
Draft
refactor(pytorch): replace backend operator builders with typed build specs#4890grimoire wants to merge 12 commits into
grimoire wants to merge 12 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PyTorch operators were constructed through
OpTypeand one-method builderclasses. This separated the operator identity, construction arguments, and
returned implementation type across multiple abstractions, making dispatch
harder to understand and extend.
Note
Since we have change the route of build_op, we better not merge this PR before other PRs that contain new ops.
Changes
BuildSpec[ImplT]objects as the operator constructioncontract.
get_layer_impl_builder()withOpsBackend.build_op(spec).OpTypeand legacy one-method builder classes.and lazy imports.
public NN APIs.
enable_deterministicconstruction seam for futuredeterministic kernels. It is currently a no-op and is not exposed through
the public configuration.
This is a construction-time dispatch refactor. It does not intentionally
change operator forward behavior or kernel selection.