fix: include lightning rod in copper oxide flag#4886
Open
florianreuth wants to merge 1 commit into
Open
Conversation
Since 1.21.11, they can oxide as well Signed-off-by: Florian Reuth <git@florianreuth.de>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the copper oxidation block-form listener logic to also cover lightning rods by checking the new block type name once and matching multiple copper-related materials.
Changes:
- Cache
event.getNewState().getType().name()into a local variable. - Expand the block-type check from only
*COPPER*to*COPPER*or*LIGHTNING_ROD*.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Since Minecraft 1.21.11, they can oxide as well.
Description
Adds another check for lightning rods to the block form event for 1.17+ servers.
Submitter Checklist
@since TODO.