fix: correct height that FAWE ends up using for schematics #4736
+11
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Not yet tested |
Member
|
Reminder: Apply patch file |
NotMyFault
approved these changes
Oct 10, 2025
Collaborator
NotMyFault
left a comment
NotMyFault
left a comment
There was a problem hiding this comment.
Untested, but looks reasonable
Member
|
I'm quite concerned of any impact this might have on existing setups, i guess
should clear that? |
dordsor21
force-pushed
the
fix/v7/fawe-schematic-height
branch
from
22974d6 to
2fff573
Compare
- this did not end up having an impact on P2 code as it always used getMinBuildHeight when PASTE_ON_TOP was false anyway - there should not be any side effects to this as any uses this specific SCHEM_Y value are effectively normalised against it
dordsor21
force-pushed
the
fix/v7/fawe-schematic-height
branch
from
2fff573 to
f27300d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.