remove lasso + elastic net from regular checks - #224
Conversation
|
The predicament of needing this update for private CI with main sklearnex branch but it failing in public CI... |
| ) | ||
| # auto-assigned `n_jobs` drop for different CPUs | ||
| if results["n_jobs"].unique().size > 1: | ||
| if "n_jobs" in results.columns and results["n_jobs"].unique().size > 1: |
There was a problem hiding this comment.
this update should already be on main, I guess you need to rebase
|
The PR itself looks fine to me, although we can only merge it when CI is green. |
|
If they are now in preview, wouldn't it make more sense to remove them from the regular configs? |
| ) | ||
| # auto-assigned `n_jobs` drop for different CPUs | ||
| if results["n_jobs"].unique().size > 1: | ||
| if "n_jobs" in results.columns and results["n_jobs"].unique().size > 1: |
There was a problem hiding this comment.
Please merge main and rebase.
Sure, looks like there are no preview algos in regular/ so this could be a good resolution that works for both private and public CI |
458a95c to
305b6f3
Compare
Description
Ref: #168, #185, uxlfoundation/scikit-learn-intelex#3418
CI on main: http://intel-ci.intel.com/f1a99f30-60cb-f12e-bffe-724646f3d540
CI on this branch: http://intel-ci.intel.com/f1b5e609-bc80-f142-b4ed-02b0127b0ae1
Checklist:
Completeness and readability
Testing