Skip to content

remove lasso + elastic net from regular checks - #224

Merged
ethanglaser merged 1 commit into
IntelPython:mainfrom
ethanglaser:dev/eglaser-lasso-preview
Sep 22, 2026
Merged

ethanglaser merged 1 commit into
IntelPython:mainfrom
ethanglaser:dev/eglaser-lasso-preview

Conversation

@ethanglaser

@ethanglaser ethanglaser commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Description

Ref: #168, #185, uxlfoundation/scikit-learn-intelex#3418

CI on main: http://intel-ci.intel.com/f1a99f30-60cb-f12e-bffe-724646f3d540
CI on this branch: http://intel-ci.intel.com/f1b5e609-bc80-f142-b4ed-02b0127b0ae1

Checklist:

Completeness and readability

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with updates and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

@ethanglaser

Copy link
Copy Markdown
Contributor Author

The predicament of needing this update for private CI with main sklearnex branch but it failing in public CI...

)
# auto-assigned `n_jobs` drop for different CPUs
if results["n_jobs"].unique().size > 1:
if "n_jobs" in results.columns and results["n_jobs"].unique().size > 1:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this update should already be on main, I guess you need to rebase

@avolkov-intel

Copy link
Copy Markdown
Collaborator

The PR itself looks fine to me, although we can only merge it when CI is green.
One minor comment is that we probably need to ensure that preview estimators don't make it to comparison plot with sklearn that is meant for publishing but that is out of scope for this PR, we can fix it when producing the picture next time

@david-cortes-intel

Copy link
Copy Markdown
Contributor

If they are now in preview, wouldn't it make more sense to remove them from the regular configs?

)
# auto-assigned `n_jobs` drop for different CPUs
if results["n_jobs"].unique().size > 1:
if "n_jobs" in results.columns and results["n_jobs"].unique().size > 1:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge main and rebase.

@ethanglaser

Copy link
Copy Markdown
Contributor Author

If they are now in preview, wouldn't it make more sense to remove them from the regular configs?

Sure, looks like there are no preview algos in regular/ so this could be a good resolution that works for both private and public CI

@ethanglaser
ethanglaser force-pushed the dev/eglaser-lasso-preview branch from 458a95c to 305b6f3 Compare September 21, 2026 17:56
@ethanglaser ethanglaser changed the title re-add preview for lasso/enet remove lasso + elastic net from regular checks Sep 21, 2026
@ethanglaser
ethanglaser merged commit 62f89b6 into IntelPython:main Sep 22, 2026
8 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants