Move build system to meson-python - #113
Conversation
52b62f9 to
65e6561
Compare
b26da80 to
383dd0f
Compare
a9b6555 to
fa5216c
Compare
* removes setup.py and generate_mklrand_c.py * updates pyproject.toml * adds meson.build
we search for MKL with cmake. Also drop pkg-config from meta.yamls and use cmake
remove tbb from build-with-clang workflow
aligns more closely with conda-forge feedstock
f34b2ca to
02efc61
Compare
| authors = [ | ||
| {name = "Intel Corporation", email = "scripting@intel.com"} | ||
| ] | ||
| authors = [{name = "Intel Corporation"}] |
There was a problem hiding this comment.
Was the email dropped intentionally?
There was a problem hiding this comment.
I dropped it because I have no access or insight into what this email address does or is used for
There was a problem hiding this comment.
Me either, we probably need to doublecheck that.
There was a problem hiding this comment.
seems email is still in use, so we should add it back here @vlad-perevezentsev
315cca7 to
0b68ab4
Compare
| requires = ["setuptools>=77", "Cython", "numpy"] | ||
| build-backend = "mesonpy" | ||
| requires = [ | ||
| "meson-python>=0.16.0", |
There was a problem hiding this comment.
Should we align with meson.build?
| "meson-python>=0.16.0", | |
| "meson-python>=1.8.3", |
There was a problem hiding this comment.
meson and meson-python are different packages.
meson-python>=0.16.0 is the correct pin because it is the minimum backend version with PEP 639 SPDX license support
Same as in mkl_umath
https://github.com/IntelPython/mkl_umath/blob/main/pyproject.toml#L29
|
@vlad-perevezentsev |
3 participants
This PR proposes moving from
setuptoolstomeson-pythonas themkl_randombuild systemmeson-pythonis already used by NumPy and allowssetup.pyto be removed (with its logic moved into themeson.buildscript)