Skip to content

perf: avoid a redundant full-array copy in scipy.fft hfft/hfftn adapters #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndgrigorian merged 2 commits into from
Sep 22, 2026
Merged

perf: avoid a redundant full-array copy in scipy.fft hfft/hfftn adapters #382

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dc0bf6
perf: avoid a redundant full-array copy in scipy.fft hfft/hfftn adapters
Sep 21, 2026
6c1f37a
fix: remove generated doc files
jharlow-intel Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions mkl_fft/interfaces/_scipy_fft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,8 +523,10 @@ def hfft(
_check_plan(plan)
x = _validate_input(x)
norm = _swap_direction(norm)
x = np.array(x, copy=True)
np.conjugate(x, out=x)
# np.conjugate(x) already allocates a fresh array, so there is no need
# to copy x first and then conjugate it in place (which would touch
# every element twice instead of once).
x = np.conjugate(x)

with _Workers(workers):
# Note: overwrite_x is not utilized
Expand Down Expand Up @@ -626,8 +628,10 @@ def hfftn(
_check_plan(plan)
x = _validate_input(x)
norm = _swap_direction(norm)
x = np.array(x, copy=True)
np.conjugate(x, out=x)
# np.conjugate(x) already allocates a fresh array, so there is no need
# to copy x first and then conjugate it in place (which would touch
# every element twice instead of once).
x = np.conjugate(x)
s, axes = _init_nd_shape_and_axes(x, s, axes, invreal=True)

with _Workers(workers):
Expand Down
Loading