Link dpnp_backend_c against only the MKL SYCL domains it uses - #3012
Merged
Conversation
antonwolfy
marked this pull request as ready for review
August 5, 2026 15:21
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
August 5, 2026 15:21
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev3=py314h509198e_36 ran successfully. |
Collaborator
|
coverage: 78.414%. remained the same — link-to-only-used-mkl-libs into master |
github-actions Bot
added a commit
that referenced
this pull request
Aug 7, 2026
`dpnp_backend_c` linked the `MKL::MKL_SYCL` umbrella target, whose link interface pulls in *every* MKL SYCL domain. This target is defined by MKL's `MKLConfig.cmake`, so the exact DLL set it drags in depends on the MKL build, not on dpnp. This PR links the backend against only the MKL SYCL domains its sources use: * **BLAS** — `oneapi::mkl::blas::scal` * **RNG** — `oneapi::mkl::rng` engines/distributions and the VSL C API * **VM** — `oneapi::mkl::vm` vector math (`div`, `sqr`, `add`, `powx`, `sqrt`, …) `dft`, `lapack`, `sparse`, `stats`, and `data_fitting` are not referenced by any source compiled into `dpnp_backend_c`, so they are dropped from its link interface. 6ad6540
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dpnp_backend_clinked theMKL::MKL_SYCLumbrella target, whose link interface pulls in every MKL SYCL domain. This target is defined by MKL'sMKLConfig.cmake, so the exact DLL set it drags in depends on the MKL build, not on dpnp.This PR links the backend against only the MKL SYCL domains its sources use:
oneapi::mkl::blas::scaloneapi::mkl::rngengines/distributions and the VSL C APIoneapi::mkl::vmvector math (div,sqr,add,powx,sqrt, …)dft,lapack,sparse,stats, anddata_fittingare not referenced by any source compiled intodpnp_backend_c, so they are dropped from its link interface.