Skip to content

Fix tests for dpctl change to return tuples #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ndgrigorian wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −2
Open

Fix tests for dpctl change to return tuples #2945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e668108
fix tests for dpctl change to return tuples
ndgrigorian Jun 9, 2026
26b23a0
add gh-2945 to changelog
ndgrigorian Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ This release is compatible with NumPy 2.4.5.
* Replaced `.pxi` includes in `dpnp.tensor` with modular `.pxd`/`.pyx` Cython imports [#2913](https://github.com/IntelPython/dpnp/pull/2913)
* Reimplemented `dpnp.eye` and `dpnp.tensor.eye` with a branchless kernel [gh-2937](https://github.com/IntelPython/dpnp/pull/2937)
* Cleaned up Python bindings for indexing functions, renaming `usm_ndarray_take` and `usm_ndarray_put` to `py_take` and `py_put` and refactoring validation [gh-2935](https://github.com/IntelPython/dpnp/pull/2935)
* Fixed some tests which expected lists from `dpctl` functions which now return tuples (i.e., `dpctl.SyclDevice.create_sub_devices`) [gh-2945](https://github.com/IntelPython/dpnp/pull/2945)

### Deprecated

Expand Down
4 changes: 2 additions & 2 deletions dpnp/tests/tensor/test_usm_ndarray_dlpack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ def test_dlpack_from_subdevice():
sdevs = dev.create_sub_devices(partition=[1, 1])
except dpctl.SyclSubDeviceCreationError:
pytest.skip("Default device can not be partitioned")
assert isinstance(sdevs, list) and len(sdevs) > 0
assert isinstance(sdevs, tuple) and len(sdevs) > 0
try:
ctx = sdevs[0].sycl_platform.default_context
except dpctl.SyclContextCreationError:
Expand Down Expand Up @@ -603,7 +603,7 @@ def test_dlpack_from_subdevice_to_kdlcpu():
sdevs = dev.create_sub_devices(partition=[1, 1])
except dpctl.SyclSubDeviceCreationError:
pytest.skip("Default device can not be partitioned")
assert isinstance(sdevs, list) and len(sdevs) > 0
assert isinstance(sdevs, tuple) and len(sdevs) > 0
try:
ctx = sdevs[0].sycl_platform.default_context
except dpctl.SyclContextCreationError:
Expand Down
Loading