Move `_tensor_elementwise_impl` (unary) extension and use it for dpnp by vlad-perevezentsev · Pull Request #2795 · IntelPython/dpnp

vlad-perevezentsev · 2026-03-03T20:49:50Z

This PR initializes _tensor_elementwise_impl pybind11 extension in dpctl_ext.tensor and extends dpctl_ext.tensor Python API with the part of unary functions :

abs
acos
acosh
angle
atan
atanh
bitwise_invert
ceil
conj

This is the first part of the work on migrating _tensor_elementwise_impl (unary)_

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
Have you added documentation for your changes, if necessary?
Have you added your changes to the changelog?

…r and reuse them

github-actions · 2026-03-03T21:34:05Z

View rendered docs @ https://intelpython.github.io/dpnp/pull/2795/index.html

vlad-perevezentsev · 2026-03-04T12:53:59Z

dpctl_ext/tensor/libtensor/source/elementwise_functions/ceil.hpp

+
+namespace py = pybind11;
+
+namespace py = pybind11;


Suggested change

namespace py = pybind11;

…pl_unary

antonwolfy · 2026-03-09T16:26:24Z

dpctl_ext/tensor/libtensor/source/elementwise_functions/elementwise_functions.hpp

+
+#pragma once
+
+#include <algorithm>


Do we need that include?

antonwolfy · 2026-03-09T16:31:54Z

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/ceil.hpp

+#pragma once
+#pragma once


Dublicate pragma

antonwolfy · 2026-03-09T16:32:29Z

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/conj.hpp

+//===---------------------------------------------------------------------===//
+
+#pragma once
+#include <cstddef>


Missing include <complex>

antonwolfy · 2026-03-09T16:33:36Z

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/angle.hpp

+/// This file defines kernels for elementwise evaluation of ANGLE(x) function.
+//===---------------------------------------------------------------------===//
+
+#include <cmath>


Do we need <cmath> include?

antonwolfy · 2026-03-09T16:39:11Z

dpctl_ext/tensor/libtensor/source/elementwise_functions/elementwise_functions_type_utils.hpp

+
+#include <sycl/sycl.hpp>
+
+#include "dpnp4pybind11.hpp"


Do we need to include that?

antonwolfy · 2026-03-09T16:46:53Z

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/abs.hpp

+#include "kernels/dpctl_tensor_types.hpp"
+#include "kernels/elementwise_functions/common.hpp"
+
+#include "utils/offset_utils.hpp"


Seems never used (the same in other headers)

antonwolfy · 2026-03-09T16:55:26Z

dpctl_ext/tensor/libtensor/source/elementwise_functions/acos.cpp

+
+} // namespace impl
+
+void init_acos(py::module_ m)


missing namespace py = pybind11;

antonwolfy · 2026-03-09T16:58:42Z

dpctl_ext/tensor/libtensor/source/elementwise_functions/atanh.cpp

+#include "kernels/elementwise_functions/atanh.hpp"
+#include "kernels/elementwise_functions/common.hpp"
+
+namespace py = pybind11;


antonwolfy · 2026-03-09T16:59:37Z

dpctl_ext/tensor/libtensor/source/elementwise_functions/elementwise_functions.hpp

+    int nd = src_nd;
+    const py::ssize_t *shape = src_shape;
+
+    dpctl::tensor::py_internal::simplify_iteration_space(


No need to use the namespace name to access the function (here in other places)

antonwolfy · 2026-03-09T17:00:11Z

dpctl_ext/tensor/libtensor/source/elementwise_functions/elementwise_functions.hpp

+        return py::cast<py::object>(res);
+    }
+    else {
+        using dpctl::tensor::py_internal::type_utils::_dtype_from_typenum;


Suggested change

using dpctl::tensor::py_internal::type_utils::_dtype_from_typenum;

using type_utils::_dtype_from_typenum;

vlad-perevezentsev added 30 commits February 3, 2026 12:16

Rename folder dpctl to dpctl_ext

d4fd805

Add simplify_iteration_space implementation to libtensor

c040713

Extend codespell ignore list for libtensor

14b466f

Add copy_and_cast kernels to libtensor

dcc421b

Add copy_usm_ndarray_into_usm_ndarray implementation

5a9c14c

Add pybind11 bindings for dpctl_ext.tensor._tensor_impl

4f63340

Add CMake build files for dpctl_ext

634579c

Add empty __init__ to dpctl_ext/

79d40f2

Enable _same_logical_tensors in _tensor_impl

7949c17

Add device_support_queries to enable default device types

29d6c02

Enable building and packaging of dpctl_ext

936e719

Use _tensor_impl from dpctl_ext.tensor in dpnp

cd85f1e

Move put() and take() to dpctl_ext/tensor

0c6780a

Use put/take from dpctl_ext.tensor in dpnp

87e5482

Move full() to dpctl_ext/tensor

b537f30

Use full and _full_usm_ndarray from dpctl_ext in dpnp

d50f263

Update .gitignore to ignore .so files in dpctl_ext

f189dc5

Move _zeros_usm_ndarray to dpctl_ext

f9a1817

Use _zeros_usm_ndarray from dpctl_ext in dpnp_fill.py

4b8505a

Move linear-sequence implementations to dpctl_ext/tensor

61106b2

Use _tensor_impl from dpctl_ext in dpnp_utils_fft.py

a030579

Move tril()/triu() to dpctl_ext/tensor

a1d6fa3

Use tril/triu/_tril from dpctl_ext.tensor in dpnp

f1d6e56

Disable pylint no-name-in-module for dpctl_ext

6680790

Add TODO comments

263b717

Use default_device_complex_type from dpctl_ext on test_array_api_info.py

4130c1b

Remove unused build_dpctl_ext function

17ca9ab

Apply remarks for CMake files

79cb2a4

Apply remarks for c++ files

4bf080e

Remove linear-sequence implementations

cfa6cd6

vlad-perevezentsev added 16 commits March 3, 2026 04:41

Move _argmax/argmin_over_axis to _tensor_reductions_impl

c6d600a

Move ti.argmax()/argmin() to dpctl_ext.tensor and reuse them in dpnp

8ae933d

Move _prod/sum_over_axis to _tensor_reductions_impl

2ec3cc7

Move ti.sum()/prod() to dpctl_ext.tensor and reuse them in dpnp

6b27b1b

Move _logsumexp/hypot_over_axis to _tensor_reductions_impl

3041d7d

Move ti.count_nonzero()/logsumexp()/reduce_hypot() to dpctl_ext.tenso…

4872bb6

…r and reuse them

Initialize _tensor_elementwise_impl extension and move _abs

58fdef3

Move ti.abs() and reuse _abs in dpnp

d4cda7c

Move _acos/_acosh to _tensor_elementwise_impl

ec74213

Move ti.acos()/acosh() and reuse them in dpnp

d4293a2

Move _angle/_asin/_asinh to _tensor_elementwise_impl

a548dbb

Move ti.angel()/asin()/asinh() and reuse them

0cec8c3

Move _atan/_atanh to _tensor_elementwise_impl

4e10a53

Move ti.atan()/atanh() and reuse them

d509f6d

Move __bitwise_invert/_ceil/_conj to _tensor_elementwise_impl

e54114f

Move ti.bitwise_invert()/ceil()/conj() and reust them

e24b129

vlad-perevezentsev self-assigned this Mar 3, 2026

vlad-perevezentsev commented Mar 4, 2026

View reviewed changes

antonwolfy mentioned this pull request Mar 4, 2026

Restructure dpctl, delegating all array functionality to dpnp #2743

Open

vlad-perevezentsev marked this pull request as ready for review March 5, 2026 10:57

vlad-perevezentsev requested review from antonwolfy and ndgrigorian as code owners March 5, 2026 10:57

vlad-perevezentsev added 5 commits March 5, 2026 10:43

Merge include-dpctl-tensor into move_tensor_accumulation_impl

ada8a5c

Apply remarks

85ef3e0

Merge move_tensor_accumulation_impl into move_tensor_sorting_impl

6e40f22

Merge move_tensor_sorting_impl into move_tensor_reductions_impl_ext

c9644ac

Merge move_tensor_reductions_impl_ext into move_tensor_elementwise_im…

6a2c31b

…pl_unary

antonwolfy reviewed Mar 9, 2026

View reviewed changes

Base automatically changed from move_tensor_reductions_impl_ext to include-dpctl-tensor March 10, 2026 15:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move `_tensor_elementwise_impl` (unary) extension and use it for dpnp#2795

Move `_tensor_elementwise_impl` (unary) extension and use it for dpnp#2795
vlad-perevezentsev wants to merge 160 commits intoinclude-dpctl-tensorfrom
move_tensor_elementwise_impl_unary

vlad-perevezentsev commented Mar 3, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

vlad-perevezentsev Mar 4, 2026

Uh oh!

antonwolfy Mar 9, 2026

Uh oh!

antonwolfy Mar 9, 2026

Uh oh!

antonwolfy Mar 9, 2026

Uh oh!

antonwolfy Mar 9, 2026

Uh oh!

antonwolfy Mar 9, 2026

Uh oh!

antonwolfy Mar 9, 2026

Uh oh!

antonwolfy Mar 9, 2026

Uh oh!

antonwolfy Mar 9, 2026

Uh oh!

antonwolfy Mar 9, 2026

Uh oh!

antonwolfy Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	using dpctl::tensor::py_internal::type_utils::_dtype_from_typenum;
	using type_utils::_dtype_from_typenum;


		#pragma once

		#include <algorithm>

		#pragma once
		#pragma once


		#include <sycl/sycl.hpp>

		#include "dpnp4pybind11.hpp"

Conversation

vlad-perevezentsev commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vlad-perevezentsev commented Mar 3, 2026 •

edited

Loading