Add missing device info queries - #2324
Open
ndgrigorian wants to merge 14 commits into
Open
Conversation
ndgrigorian
requested review from
antonwolfy and
vlad-perevezentsev
as code owners
June 12, 2026 00:30
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2324/index.html |
Collaborator
|
coverage: 74.054% (-0.5%) from 74.579% — add-missing-device-info-queries into master |
antonwolfy
reviewed
Jul 8, 2026
ndgrigorian
force-pushed
the
add-missing-device-info-queries
branch
from
August 3, 2026 22:33
368514e to
38b62bf
Compare
antonwolfy
reviewed
Aug 4, 2026
ndgrigorian
force-pushed
the
add-missing-device-info-queries
branch
from
August 4, 2026 18:18
17ce890 to
03911c8
Compare
ndgrigorian
force-pushed
the
add-missing-device-info-queries
branch
from
August 4, 2026 18:27
03911c8 to
75030b5
Compare
antonwolfy
previously approved these changes
Aug 5, 2026
antonwolfy
left a comment
antonwolfy
left a comment
Collaborator
There was a problem hiding this comment.
LGTM with only small question below
antonwolfy
reviewed
Aug 5, 2026
| */ | ||
| typedef enum | ||
| { | ||
| DPCTL_PARTITION_AFFINITY_DOMAIN_UNKNOWN = 0, |
Collaborator
There was a problem hiding this comment.
Is not that a is a numeric-ABI change to already available API? We should at least state that explicitly.
Collaborator
Author
There was a problem hiding this comment.
it is though this PR is not yet part of any release, and would only impact bleeding-edge builds
where do you feel it should be stated, changelog?
Collaborator
Author
There was a problem hiding this comment.
added it to the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing SYCL 2020 spec (i.e., non-extension) device info queries to
dpctl.SyclDevice