Skip to content

Fix Firefox option smoke test and fail on startup errors - #122

Merged
JE-Chen merged 1 commit into
mainfrom
dev
Oct 11, 2026
Merged

JE-Chen merged 1 commit into
mainfrom
dev

Conversation

@JE-Chen

@JE-Chen JE-Chen commented Oct 11, 2026

Copy link
Copy Markdown
Member

The Firefox option smoke script passed Selenium Options objects to a manager API that expects argument lists, then reported the resulting TypeError as a successful skip. Pass headless argument lists, require both browser instances to exist, and close them in finally. Startup errors now fail CI.

Validation: local Ruff passed. Merge only after all CI checks, SonarCloud and Codacy pass on the reviewed head, including the real Firefox smoke in every Python browser job.

@sonarqubecloud

Copy link
Copy Markdown

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@JE-Chen
JE-Chen merged commit 5de1e2d into main Oct 11, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant