Merged
Conversation
Address the 95 pylint findings Codacy reported on dev. Changes are split between real code fixes and configuration where the rule fires on an idiomatic pattern pylint doesn't understand. - core/config.py: move the tomllib/tomli conditional into a helper so all module-level imports stay at the top (5 C0413 fixes). - core/dag_executor.py: justify the Template-Method protected-access call with an inline pylint disable. - tests: rewrite `x == []` assertions to `not x`, drop truly unused `tmp_path` params, convert pytest fixtures to the `@pytest.fixture(name=...)` + `_foo` pattern so they no longer shadow the test-param name, and switch `patch_validator` callers to `@pytest.mark.usefixtures`. Strengthen the FTP tests that receive `fake_ftp` purely for side effects by asserting on its recorded state. Add targeted `protected-access` disables where tests probe internals intentionally. - .pylintrc: disable R0401 (cyclic-import) and R0801 (duplicate-code) project-wide with rationale — the cloud-backend cycle is a runtime lazy import, and the duplicate-code warnings fire on the parallel remote client wrappers by design. Verified: `ruff check`, `ruff format --check`, and the full pytest suite (651 passed, 8 skipped) all pass.
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruff check,ruff format --check, and the full pytest suite (651 passed, 8 skipped) all pass.Highlights
Source
automation_file/core/config.py— move thetomllib/tomliconditional into a_load_tomllib()helper so module-level imports stay at the top (fixes 5 C0413).automation_file/core/dag_executor.py— justify the intra-package call toActionExecutor._execute_eventwith an inlineprotected-accessdisable..pylintrc— addR0401(cyclic-import) andR0801(duplicate-code) to the project-level disables, each with a rationale comment. The cycle is a runtime-safe lazy import; the duplicate-code warnings fire on the parallelS3Client/AzureBlobClient/DropboxClient/FTPClient/SFTPClientwrappers that intentionally share a minimal skeleton.Tests
x == []assertions tonot x.@pytest.fixture(name=\"foo\")+_foopattern so they no longer shadow the test-parameter name (fixes all 44 W0621).tmp_pathparameters (test_dir_ops, test_file_ops, test_substitution).patch_validatorcallers to@pytest.mark.usefixturesand strengthen FTP tests that previously receivedfake_ftponly for side effects to now assert against its recorded state.protected-accessdisables where tests deliberately probe internals (Prometheus._value,cross_backend._split,AuditLog._db_path,Scheduler._dispatch,fast_find._run_indexer).lambda tag: seen.append(tag)in test_callback_executor with a disable —list.appendrejects kwargs, so the lambda is necessary.Test plan
ruff check automation_file/ tests/ruff format --check automation_file/ tests/pytest tests/— 651 passed, 8 skipped