Conversation
Lift the ``http`` scheme into a named constant with a NOSONAR justification
so the static analyzer sees intent ("localhost-only ephemeral test server;
TLS is out of scope") rather than a bare ``http://`` URL literal. The test
still hits the same local server in the same way.
- rest_server: rename _JSONHandler.log_message parameter back to ``format`` so the signature matches BaseHTTPRequestHandler, silencing PyLint W0221 (arguments-renamed); add a pylint disable comment because the name deliberately shadows the builtin - conf.py: add ``# pylint: disable=redefined-builtin`` next to the existing ruff noqa for Sphinx's required ``copyright`` global (W0622) - clipboard._linux_get/_linux_set: annotate the two subprocess.run calls with nosemgrep for dangerous-subprocess-use-audit; the argv list is built from an allowlist (xclip/xsel) located via shutil.which - shell_process.exec_shell: same nosemgrep annotation on the Popen call; argv is shlex-split then validated by ``_normalize_command``
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small analyzer follow-ups caught after PR #175 merged.
test_rest_server.py:21: extract_TEST_SCHEME = "http"constant with aNOSONARjustification. The test hits an ephemeral localhost server on port 0; TLS is out of scope.conf.pyredefined-builtinon Sphinx's requiredcopyrightglobal (PyLint W0622)_JSONHandler.log_messagesignature lined up withBaseHTTPRequestHandler.log_message(W0221)nosemgrepon the three dynamic-argv subprocess calls inclipboard._linux_get/_linux_setandshell_exec.exec_shell— argv is allowlisted viashutil.whichor validated by_normalize_commandTest plan
python -m pytest test/unit_test/headless test/unit_test/flow_control— 139 passed locallypython -m ruff check je_auto_control/ test/— cleanpython -m bandit -r je_auto_control/ -c pyproject.toml— 0 issues