Skip to content

chore: upgrade safe-settings to 2.1.19, harden workflow #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nbrieussel wants to merge 1 commit into from
Closed

chore: upgrade safe-settings to 2.1.19, harden workflow #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/safe-settings-sync.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,12 @@ on:
jobs:
sync:
name: Sync org settings${{ github.event.inputs.nop == 'true' && ' (dry-run)' || '' }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 30
permissions:
contents: read
env:
SAFE_SETTINGS_VERSION: 2.1.17
SAFE_SETTINGS_VERSION: 2.1.19
SAFE_SETTINGS_CODE_DIR: ${{ github.workspace }}/.safe-settings-code
steps:
- name: Checkout admin repo (settings source)
Expand All @@ -34,7 +35,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: github/safe-settings
ref: ${{ env.SAFE_SETTINGS_VERSION }}
ref: ${{ env.SAFE_SETTINGS_VERSION }} # pin: 6a8b6ae084987025f6c5de85e3cc6df140f64502
path: ${{ env.SAFE_SETTINGS_CODE_DIR }}

- name: Setup Node.js
Expand All @@ -45,7 +46,7 @@ jobs:
cache-dependency-path: ${{ env.SAFE_SETTINGS_CODE_DIR }}/package-lock.json

- name: Install dependencies
run: npm install
run: npm ci
working-directory: ${{ env.SAFE_SETTINGS_CODE_DIR }}

- name: Run full sync
Expand Down
5 changes: 2 additions & 3 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,8 @@ These are **already worked around** in this repo — do not undo them:
up listed twice and the API rejects it. Set bypass **only** in `settings.yml`.

4. **probot v14 full-sync break** — fixed in 2.1.19+ via
[PR #949](https://github.com/github/safe-settings/pull/949). The version is currently pinned to
`2.1.17` in `.github/workflows/safe-settings-sync.yml` (`SAFE_SETTINGS_VERSION`). Upgrading to
`2.1.19` is safe; always do a dry-run first.
[PR #949](https://github.com/github/safe-settings/pull/949). The version is now running `2.1.19`
in `.github/workflows/safe-settings-sync.yml` (`SAFE_SETTINGS_VERSION`).

## Open hygiene issues (tracked in this repo's GitHub Issues)

Expand Down