STYLE: Replace ULL with IT as index type in itkPyVectorContainerTest.py

[N-Dekker]

Removed the check for sufficient wrapping from "Modules/Bridge/NumPy/wrapping/test/itkPyVectorContainerTest.py". itk.VectorContainer is always sufficiently wrapped for itk.IT.

• Follow-up to pull request STYLE: Replace UL with IT as index type in itkPyVectorContainerTest.py #6800 (which was about the other "itkPyVectorContainerTest.py" file, in "Filtering/MeshToPolyData/wrapping/test").

[dzenanz]

Looks good on a glance.

[greptile-apps]

Greptile Summary

This change switches the NumPy VectorContainer test to itk.IT indices and removes its availability check. The updated test now fails in supported reduced Python-wrapping builds that omit float wrapping or the 2D point specialization, where the previous test skipped successfully. Restore the availability guard or register the test only when its required float, 2D, and 3D templates are wrapped.

Confidence Score: 4/5

Not safe to merge until the test handles reduced wrapping configurations without failing.

A direct before-and-after execution reproduced missing-template failures when float wrapping is disabled and when 2D point wrapping is excluded.

Files Needing Attention: Modules/Bridge/NumPy/wrapping/test/itkPyVectorContainerTest.py needs an availability guard or equivalent conditional registration.

T-Rex Logs

What T-Rex did

• T-Rex published a finding-comment-proof for the P1 finding and attached a reproduction source and test-run logs to support review.
• T-Rex published a second finding-comment-proof for the same P1 finding to document ongoing validation.
• T-Rex documented a general-contract-validation-proof that explains how specific ITK wrap gates lead to KeyError and recommends a guard or conditional test registration.

_{Ran code and verified through T-Rex}

Comments Outside Diff (1)

1. General comment

   Vector-container NumPy test no longer skips unavailable float/2D wrapping

   • Bug
     • The test is registered whenever Python wrapping is enabled, but it now unconditionally requests float scalar and 2D/3D point specializations. Builds with ITK_WRAP_float=OFF, or with dimension 2 excluded, fail the test instead of reporting insufficient wrapping and returning successfully.
   • Cause
     • The PR removed the runtime availability guard. The scalar IT,F specialization depends on WRAP_ITK_REAL (which excludes float when ITK_WRAP_float=OFF), while IT,P<F,d> is generated only for dimensions in ITK_WRAP_IMAGE_DIMS.
   • Fix
     • Restore a guard that verifies the required IT-indexed scalar and Point 2/3 vector-container templates, or gate registration in CMake on ITK_WRAP_float and both 2 and 3 being selected.

   _{Ran code and verified through T-Rex}

_{Reviews (1): Last reviewed commit: "STYLE: Replace ULL with IT as index type..." | Re-trigger Greptile}

[greptile-apps]

Conditional wrappings go unchecked

The test is registered for every Python-wrapping build, but it now unconditionally requests the IT,F vector-container specialization and float Point vector containers in dimensions 2 and 3. Those templates are intentionally absent when ITK_WRAP_float=OFF or when either dimension is omitted from ITK_WRAP_IMAGE_DIMS, so these supported reduced configurations fail template lookup instead of skipping the test. Restore an equivalent availability guard, or only register this test when float plus dimensions 2 and 3 are wrapped.

Context Used: AGENTS.md (source)

Artifacts

Narrow vector-container wrapping reproduction source

• The review-authored Python harness executes the parent and current test sources against the wrapping availability rules, with the takeaway that unavailable specializations are exercised directly.

Parent test run with float disabled and 2D excluded

• The executed parent-source run prints its insufficient-wrapping skip and returns successfully for both reduced configurations, with the takeaway that the prior behavior was to skip.

Current test run with float disabled and 2D excluded

• The executed current-source run reports missing `IT,F` when float is disabled and missing float Point 2D when dimension 2 is excluded, with the takeaway that the claimed regression is reproduced.

_{Ran code and verified through T-Rex}