WIP: Replace UI with IT as index type for LevelSetNode VectorContainer - #6803
Draft
N-Dekker wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
Still under construction. I see now: in C++, |
`itk.IT` ("IdentifierType") is the most commonly supported index type for
VectorContainer.
Adjusted `ShapePriorMAPCostFunctionBase::NodeContainerType` to use the default
index type of `itk::VectorContainer` (which is equal to `IdentifierType`).
Follow-up to pull request InsightSoftwareConsortium#6800
commit 0939d4c
"STYLE: Replace UL with IT as index type in itkPyVectorContainerTest.py"
N-Dekker
force-pushed
the
Replace-UI-with-IT-index-type-LevelSetNode-VectorContainer
branch
from
August 26, 2026 13:47
5bb4e81 to
67912ce
Compare
Contributor
Author
|
This force-pushed amend aims to address CI failures at https://open.cdash.org/tests/2723817696 saying: |
dzenanz
approved these changes
Aug 26, 2026
N-Dekker
commented
Aug 26, 2026
|
|
||
| /** Type of container used to store the level set nodes. */ | ||
| using NodeContainerType = VectorContainer<unsigned int, NodeType>; | ||
| using NodeContainerType = VectorContainer<NodeType>; |
Contributor
Author
There was a problem hiding this comment.
This is a potentially breaking change, although in practice, VectorContainer<unsigned int, NodeType> and VectorContainer<NodeType> behave exactly the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
itk.IT("IdentifierType") is the most commonly supported index type for VectorContainer. (VectorContainer is wrapped for IT and UC, but not for UI, as index type.)