COMP: Update DCMTK to add printf format attribute in offile.h#6587
Open
hjmjohnson wants to merge 1 commit into
Open
COMP: Update DCMTK to add printf format attribute in offile.h#6587hjmjohnson wants to merge 1 commit into
hjmjohnson wants to merge 1 commit into
Conversation
OFFile::fprintf and OFFile::vfprintf forward a non-literal format string to ::vfprintf, warning in every ITK translation unit that includes offile.h. The format attribute silences the false positive and adds format/argument checking at call sites.
8582e46 to
2300b0b
Compare
Contributor
|
| Filename | Overview |
|---|---|
| Modules/ThirdParty/DCMTK/DCMTKGitTag.cmake | Updates the DCMTK FetchContent commit pin and patch-list comment while keeping the same release-anchored fork branch. |
Reviews (1): Last reviewed commit: "COMP: Update DCMTK to add printf format ..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the vendored DCMTK to add
__attribute__((format(printf, ...)))toOFFile::fprintf/OFFile::vfprintf, fixing two clang-Wformat-nonliteralwarnings emitted in every ITK translation unit that includesoffile.h(e.g. viaitkDCMTKFileReader.h).Details
for/itk-dcmtk-3.7.0-ccfd10b.formatparameter as a valid forwarding target (silencing the wrapper-internal false positive) and enables format/argument checking at all call sites.ITKIODCMTKTestDriverrebuild (all of DCMTK + ITK IODCMTK tests) against the new pin with zero warnings/errors.