Conversation
…election In step 2 of workout creation (TrainScreen review), users are presented with a default selection of exercises based on the selected muscles. Currently, clearing all picks to build a workout from scratch requires deselecting each exercise individually. Conversely, if a user wants to restore the default recommendations, they have to navigate back and forth. This commit adds a reset/clear button (using arrowCounterClockwise) in the search bar row: - When picks are not empty: tapping clears all picks - When picks are empty: tapping restores the default recommended picks - State helpers: WorkoutState.clearPicks(), resetDefaultPicks(), toggleResetPicks() - Includes unit tests in flow_test.dart and widget test in train_step2_test.dart
- Added 14 new gymnastics ring exercise names to kExerciseNameZh in catalog_zh.dart. - Added corresponding full 5-step instructions to kExerciseStepsZh in catalog_zh.dart. - Now all 543 catalog exercises have 100% complete names and steps in Simplified Chinese.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
catalog_zh.dartfor the 14 new gymnastics ring exercises introduced in 1.2.0.isScrollControlled: trueandSingleChildScrollViewto the language bottom sheet inSettingsScreenso all 6 supported languages fit cleanly without being clipped on smaller screens.Key Changes
WorkoutState: AddedclearPicks(),resetDefaultPicks(), andtoggleResetPicks().TrainScreen: Added the reset button in Step 2 search bar with dynamic styling matching active picks state.catalog_zh.dart: Added Chinese entries for 14 ring exercises (rNG1dip~rNGemus) inkExerciseNameZhandkExerciseStepsZh.settings_screen.dart: Enabled scrolling and full-height support for language selection bottom sheet.test/flow_test.dart: Unit tests for state transitions oftoggleResetPicks().test/train_step2_test.dart: Widget test for button display, dynamic colors, and tap behavior.test/i18n_test.dart&test/exercise_alias_test.dart: All passed.Verification
flutter test: All tests passed.